Skip to content
This repository has been archived by the owner on Dec 11, 2023. It is now read-only.

All in with tags (v4.0.0) #158

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

All in with tags (v4.0.0) #158

wants to merge 10 commits into from

Conversation

drio
Copy link
Contributor

@drio drio commented Jan 24, 2017 •
edited
Loading

(WIP)

@niklibrato
Copy link

@drio can we help with completing this? Just had an issue with a user requesting beta access to tags because the readme says it is still in beta... 😢

@drio
Copy link
Contributor Author

drio commented Jul 18, 2017

@drio can we help with completing this? Just had an issue with a user requesting beta access to tags because the readme says it is still in beta... 😢

Hey, Nik. This branch was an attempt to completely remove SD references. The current version of the bindings (3.0.1) contains all the necessary functionality to fully work in Tag mode (and SD mode). Still, if the user is missing functionality, please let me know, and I'll be happy to add it here.

@niklibrato
Copy link

Agreed with @drio that we should do tags first similar to how we handle they ruby gem and statsd backend.

@gmckeever
Copy link
Contributor

+1 on merging this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gmckeever gmckeever gmckeever approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drio @niklibrato @gmckeever