Bump minSdk to 26 #7047
Draft
Bump minSdk to 26 #7047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pittvandewitt
commented
Jan 29, 2025
| @@ -29,7 +28,7 @@ object LocaleHelper { | |||
|
|
|||
| fun updateLanguage(context: Context) { | |||
| val locale = getAppLocale() | |||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) updateResources(context, locale) | |||
There was a problem hiding this comment.
Wasn't this meant to be an if else check, or is it intentional to always call updateResourcesLegacy?
Pittvandewitt
commented
Jan 29, 2025
| val (timeAgoRes, time) = if (years > 0) { | ||
| R.plurals.years_ago to years | ||
| } else { | ||
| R.plurals.months_ago to months |
There was a problem hiding this comment.
These plurals are no longer used. They could be removed from the translations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #7039 and #6986 I took the freedom to bump the minSdk to 26