feat: Implement splash screen for older Android versions #7154
+55
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bnyro
reviewed
Mar 3, 2025
| <vector | ||
| android:width="64dp" | ||
| android:height="64dp" | ||
| android:tint="?attr/colorSecondary" |
There was a problem hiding this comment.
I assume that this color has been intentionally removed for compatibility reasons?
With the default tint, the background contrast is quite bad on the dark theme with SDK >= 31.
There was a problem hiding this comment.
Yeah, that wasn't being used. Will revert that change and check again.
There was a problem hiding this comment.
I tried reverting the tint change, but the icon is always a black icon then, so I kept the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a splash screen similar to the one on Android 12+ for older versions of Android using the Core Splashscreen library.
This guide has more information on its features and limitations.
Screen_recording_20250303_075654.mp4
Screen_recording_20250303_075714.mp4