Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add service discovery #920

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

luandro
Copy link
Contributor

@luandro luandro commented Mar 8, 2022

Work in progress

Just a WIP of how I imagine service discovery could work with LibreMesh and Lime-App.

@luandro luandro changed the title WIP: Add services for service discovery WIP: Add service discovery Mar 8, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #920 (7582ecd) into master (bf2bac2) will not change coverage.
The diff coverage is n/a.

❗ Current head 7582ecd differs from pull request most recent head df6da95. Consider uploading reports for the commit df6da95 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #920   +/-   ##
=======================================
  Coverage   76.41%   76.41%           
=======================================
  Files          47       47           
  Lines        3934     3934           
=======================================
  Hits         3006     3006           
  Misses        928      928           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf2bac2...df6da95. Read the comment docs.

@ilario
Copy link
Member

ilario commented Jan 10, 2023

Hi Luandro!
I would suggest to rename the package to something more telling than just services.
Thanks!

@ilario
Copy link
Member

ilario commented Jan 10, 2023

Also, is Network > Services a new submenu?
I see only this package there.
Did you consider including this package in an already existing menu?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants