Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player: optionally use album gain for loudness normalisation #739

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

skeller
Copy link

@skeller skeller commented Oct 20, 2023

Add a new option "useAlbumGain" to optionally use album gain instead of track gain for loudness normalisation. This e.g. prevents loudness jumps in gapless mixes.

@devgianlu
Copy link
Member

I am not entirely sure what is the proper use case for using the album gain. Does it make sense to use it globally or perhaps would it be better to use it when an album is being played?

@skeller
Copy link
Author

skeller commented Nov 11, 2023

Does it make sense to use it globally or perhaps would it be better to use it when an album is being played?

I use it globally, always. This is because I like to put e.g. the discography of a band/artist into a playlist and play that. So not only when playing a single album.

@devgianlu
Copy link
Member

Sounds good to me!

@devgianlu devgianlu merged commit c8cf8d2 into librespot-org:dev Nov 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants