sdl2: add shared context by implementing sdl_ctx_bind_hw_render #18330
+35
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using RETRO_ENVIRONMENT_SET_HW_SHARED_CONTEXT with sdl2 GL RetroArch will segfault. This is because bind_hw_render is NULL and is unimplemented.
Shared context is required for webOS for the dolphin emulator.
Tested on webOS 10 on a LG G4 TV running the in development dolphin port.
Also tested trying to use Play! emulator which also requires RETRO_ENVIRONMENT_SET_HW_SHARED_CONTEXT which also crashes.
Related Issues
webosbrew/retroarch-cores#13