Ready for review: Migration to Symfony 3

[CoalaJoe]

Created this PR for you to keep track of what I am doing. Please don't be afraid to ask!
I will help where I can and add documenation where needed.

[RobLoach]

Looks like there's a broken diff/merge here?

[CoalaJoe]

Fixed it

[CoalaJoe]

Can you try to check the code, for compatibility with the current state?

[RobLoach]

Wow, nicely done!

Getting the following error when attempting to create the database:

Could not create database /home/rob/Documents/libretro-netplay-registry/app/../var/data/data.sqlite for connection named default
An exception occured in driver: SQLSTATE[HY000] [14] unable to open database file

Know how to fix the database path?

[CoalaJoe]

Ah. Git does not like empty folders. When you create the data-folder in the var-folder, it should work. I'll add a .gitkeep to that directory, so that this won't happen anymore.

[RobLoach]

Git does not like empty folders.

One common convention is to have a .gitkeep file. Oh, you said that. lol... I should read all comment before responding.

[CoalaJoe]

Tonight I'll write tests for the other APIs. So we have 100% coverage.

[RobLoach]

Very cool! I'll have another chance to test more tonight.

[CoalaJoe]

@RobLoach Thanks :) Any feedback on #37 (comment)

[CoalaJoe]

I got another idea.
1 entry per username & ip combo.
5 entries per ip.

The old entries will be replaced.
btw @fr500 is there any plan on adding a fixed username per player?

[CoalaJoe]

The latest commit is ready for review. But needs tests for lifecycle callback and entrymanagementlistener so don't merge just yet. ;)

[CoalaJoe]

It is ready for a review.

[CoalaJoe]

@RobLoach @fr500 Any feedback on when you have time to review it?

[CoalaJoe]

Anything?

[RobLoach]

Looks great from my perspective. Tested it a bit ago and entries were added correctly. Even set up an Apache local host and the routes picked up correctly.

I'd be open to merging! @fr500, think we're ready? We could test this on a different branch on lobby.libretro.com if you want to make sure it works on the server beforehand.

[andres-asm]

@bparker kinda took over and I'm not sure... I think he rewrote the whole thing in Python

…

On Mon, Mar 6, 2017, 1:15 AM Rob Loach ***@***.***> wrote: Looks great from my perspective. Tested it a bit ago and entries were added correctly. Even set up an Apache local host and the routes picked up correctly. I'd be open to merging! @fr500 <https://github.com/fr500>, think we're ready? We could test this on a different branch on lobby.libretro.com if you want to make sure it works on the server beforehand. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#37 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABpC0Dixo29Td288idzdMQqT5UCKggSfks5ri6SXgaJpZM4MEiqW> .

[CoalaJoe]

@fr500 cool...
So what now?

[CoalaJoe]

Seems like @bparker06 didn't do anything in his fork.
@fr500 what do we do?

[RobLoach]

This one: https://github.com/libretro/netplay-lobby-server

[CoalaJoe]

I am closing this PR due to the current state of this repository.
It's a pitty that so much effort has been wasted, but there is nothing I can do.

[andres-asm]

it's not really our fault either, @RobLoach at least was aware that this thing was coded on a whim, on a weekend were I decided we were gonna have a netplay quick connect feature, he was available and he helped me with the PHP side of things.

It was developed as a sort of proof of concept and nothing else.

[RobLoach]

@fr500 Is there anything holding us back from merging this one though? It's a lot better then what's on lobby.libretro.com right now. Even though newlobby is coming, this will keep us going until it's switched with the Python one.

Also, this has tests 😉

[andres-asm]

We migrated already... I don't know really, this is off my hands now