Windows trays: Fix fetching parent entry from submenu, allow enabling and disabling entries that aren't checkboxes #12003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test/testtray program would crash on Windows when adding any item and then removing it, because a submenu's parent_entry field was not set.
Additionally, I noticed that some extraneous code copied from the {G,S}etTrayEntryChecked made {G,S}etTrayEntryEnabled work only for checkboxes, which is not the desired behavior.
Both issues were fixed in this commit.
Semphriss
force-pushed
the
tray-win-fixes
branch
from
1cb8afc to
a24da87
Compare
|
I've pushed a new commit so that |
The API states that the related functions must return NULL if the function called (get the parent tray, or get the parent entry) is invalid for this menu. Initialising the fields to NULL makes that API correct for Windows.
Semphriss
force-pushed
the
tray-win-fixes
branch
from
a24da87 to
82d8d4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
test/testtrayprogram would crash on Windows when adding any item and then removing it, because a submenu's parent_entry field was not set.Additionally, I noticed that some extraneous code copied from the
{G,S}etTrayEntryCheckedmade{G,S}etTrayEntryEnabledwork only for checkboxes, which is not the desired behavior.Both issues were fixed in this commit.
Relatedly, it may be worth to take some time before the first full release to exhaustively test trays and dialogs on all platforms. I did some summary testing on Windows, but I can write extensive unit tests that can quickly be run on all platforms, so that we won't need to manually try every possible combination to find embarrassing mistakes like these two.
Existing Issue(s)
Fixes #12002