gpu/vulkan : fix clear value indexing #13967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flibitijibibo
approved these changes
Sep 16, 2025
thatcosmonaut
approved these changes
Sep 16, 2025
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the indexing in the loop setting the clear values passed to the
VkRenderPassBeginInfostruct.Description
We fix an indexing error where
iwas allowed to exceed the length ofcolorTargetInfoswhich isnumColorTargets. The solution is to set the index ofclearValuesseparately (it should also be aligned with the index of the full color attachments array according to the docs).