Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge updated code from seapagan/lice2 #59

Open
wants to merge 180 commits into
base: master
Choose a base branch
from

Conversation

seapagan
Copy link

@seapagan seapagan commented Jan 16, 2025

Merge in changes from my repo seapagan/lice2 as requested by @jcarbaugh. I will be taking over maintenance of this project going forward.

This modernises the code and fixes a few bugs, allowing it running on python versions up to 3.13 - However the MINIMUM version of Python suported is now 3.9

I have added a lot of tests, type-hints and converted the project to use uv for dependency management etc. There are also a couple of CI actions.

seapagan and others added 30 commits August 18, 2024 11:27
Signed-off-by: Grant Ramsay <[email protected]>
Signed-off-by: Grant Ramsay <[email protected]>
Signed-off-by: Grant Ramsay <[email protected]>
Signed-off-by: Grant Ramsay <[email protected]>
Signed-off-by: Grant Ramsay <[email protected]>
Signed-off-by: Grant Ramsay <[email protected]>
Signed-off-by: Grant Ramsay <[email protected]>
Signed-off-by: Grant Ramsay <[email protected]>
Signed-off-by: Grant Ramsay <[email protected]>
Signed-off-by: Grant Ramsay <[email protected]>
Signed-off-by: Grant Ramsay <[email protected]>
Signed-off-by: Grant Ramsay <[email protected]>
Signed-off-by: Grant Ramsay <[email protected]>
Signed-off-by: Grant Ramsay <[email protected]>
Signed-off-by: Grant Ramsay <[email protected]>
otherwise it defaults to 3.8 which causes issues d/t the import
re-defining

Signed-off-by: Grant Ramsay <[email protected]>
it chokes on GitHub but works locally. For some reason it will NOT agree
to run as Python 3.9

Signed-off-by: Grant Ramsay <[email protected]>
Signed-off-by: Grant Ramsay <[email protected]>
Refactor with strict ruff and mypy linting
@seapagan seapagan self-assigned this Jan 16, 2025
@seapagan seapagan changed the title Merge updated from seapagan/lice2 into this repo. Merge updated from seapagan/lice2 Jan 16, 2025
@seapagan seapagan changed the title Merge updated from seapagan/lice2 Merge updated code from seapagan/lice2 Jan 16, 2025
@seapagan
Copy link
Author

@jcarbaugh this is pretty much ready to merge, but I don't want to do until you confirm I have PyPI access so the code and package don't get terribly out of sync. Also I sent a couple questions to your email. TIA.

@seapagan seapagan marked this pull request as ready for review January 27, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant