Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hardcode 960 positions #622

Closed
wants to merge 1 commit into from

Conversation

allanjoseph98
Copy link
Member

No description provided.

@ornicar
Copy link
Collaborator

ornicar commented Feb 12, 2025

Nice and crafty, but is it better? It probably compiles slower and runs slower, and doesn't seem more readable to me.

So... why the change?

@allanjoseph98
Copy link
Member Author

@lenguyenthanh
Copy link
Member

I don't think this change affects perf tests's result anyway. Because this only affects the start up time and perf tests mostly measure things after the jvm is warm.

@ornicar ornicar closed this Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants