Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot set Lido withdrawal credentials using the UI #133

Closed
skozin opened this issue Nov 13, 2020 · 3 comments · Fixed by #160
Closed

Cannot set Lido withdrawal credentials using the UI #133

skozin opened this issue Nov 13, 2020 · 3 comments · Fixed by #160
Assignees
Labels
bug Something isn't working UI
Milestone

Comments

@skozin
Copy link
Member

skozin commented Nov 13, 2020

Nothing happens when one tries to update DAO withdrawal credentials using the client UI.

Steps

  1. Open DAO client interface, make sure DAO holder account is active.
  2. Go to Lido app.
  3. Press Edit button on Withdrawal Credentials line.
  4. Enter 00f45d8e2c47371928bfeca7a52b7e0b67f4c0aa0f10d3ecebf7381158acf4cd in the field.
  5. Press "Set withdrawal credentials".

Expected result

The app offers to start the voting process.

Actual result

Nothing happens.

Notes

Nothing happens if one selects an account that holds no DAO (LDO) tokens, too.

@skozin skozin added the bug Something isn't working label Nov 13, 2020
@skozin skozin added this to the Testnet milestone Nov 13, 2020
@skozin skozin added the UI label Nov 14, 2020
@skozin
Copy link
Member Author

skozin commented Nov 17, 2020

It started working for some reason. @azat-s, feel free to close this if you fail to reproduce.

@mymphe
Copy link
Contributor

mymphe commented Nov 19, 2020

@skozin
It seems the method only accepts hexadecimal strings prefixed with '0x'.
As per issue #149, I will add some validation rules. E.g. the string must be prefixed with '0x' and must be of length n, which is how many exactly (not counting the prefix)?

Alternatively, I can add the prefix the string myself, if none is present.

@skozin
Copy link
Member Author

skozin commented Nov 19, 2020

string must be prefixed with '0x' and must be of length n

The withdrawal credentials is a 32-byte number, so the string must contain 64 characters excluding the 0x prefix.

Alternatively, I can add the prefix the string myself, if none is present

Yep, that would be perfect!

@mymphe mymphe linked a pull request Nov 20, 2020 that will close this issue
tamtamchik added a commit that referenced this issue Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants