[aragon][Lido] validate when setting withdrawal credentials #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skozin
reviewed
Nov 21, 2020
| .required() | ||
| .test( | ||
| 'credentials', | ||
| 'Credentials must be a 64-character hexadecimal number', |
There was a problem hiding this comment.
Let's better say "Credentials must be a 32-byte hexadecimal number"
skozin
approved these changes
Nov 23, 2020
dechjo
pushed a commit
to dechjo/lido-dao
that referenced
this pull request
Jan 26, 2021
[aragon][Lido] validate when setting withdrawal credentials
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performs validation before submitting new withdrawal credentials to vote. Also, added a better-looking badge for withdrawal credentials, which copies them to clipboard on click.
WC input field:
/^[a-fA-F0-9]{64}$/) not counting the '0x' prefix.Before submitting, the '0x' prefix is added to the beginning of the number, if none is present.
WC Badge
WC Badge (copied to clipboard)
Validation Demo
