Feat/sr3 alloc fix #1586
Open
Feat/sr3 alloc fix #1586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| uint256[] memory shares = SRStorage.getSTASStorage().sharesOf(_moduleIds, uint8(Strategies.Deposit)); | ||
| uint256[] memory balances = new uint256[](n); | ||
| uint256[] memory capacities = new uint256[](n); | ||
| AllocationState memory allocState; |
Check warning
Code scanning / Slither
Uninitialized local variables Medium
| { | ||
| uint256 n = _moduleIds.length; | ||
| uint256[] memory balances = new uint256[](n); | ||
| AllocationState memory allocState; |
Check warning
Code scanning / Slither
Uninitialized local variables Medium
|
|
||
| if (targets[i] == 0) --count; | ||
| if (capacity > 0) { | ||
| uint256 demand; |
Check warning
Code scanning / Slither
Uninitialized local variables Medium
|
Hardhat Unit Tests Coverage SummaryDiff against masterResults for commit: b715b2e Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short summary of the changes.
Context
What the reviewer needs to know
Problem
What problem this PR solves, link relevant issue if it exists
Solution
Your proposed solution