Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve DAO deploy script and template #164

Merged
merged 2 commits into from
Nov 22, 2020
Merged

Improve DAO deploy script and template #164

merged 2 commits into from
Nov 22, 2020

Conversation

skozin
Copy link
Member

@skozin skozin commented Nov 22, 2020 •
edited
Loading

This PR contains several little improvements to #153:

  1. DAO deploy is fixed in the case when deployed.json contains a non-updated DAO initial config.
  2. Beacon spec is stored in an object instead of an array (improves readability).
  3. Beacon spec is not saved in the template's storage since it's not needed.
  4. Allows configuring Lido apps' deployment params via env. variables.

@skozin skozin requested a review from ongrid November 22, 2020 12:27
@skozin skozin changed the title Improve DAO deploy script Improve DAO deploy script and template Nov 22, 2020
@ongrid ongrid merged commit 6d5cff2 into lip_3_oracle Nov 22, 2020
@ongrid ongrid deleted the lip_3_oracle_deploy_fixes branch November 22, 2020 15:24
@ongrid ongrid restored the lip_3_oracle_deploy_fixes branch November 22, 2020 18:58
@ongrid ongrid deleted the lip_3_oracle_deploy_fixes branch November 22, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ongrid ongrid ongrid approved these changes

Assignees

@ongrid ongrid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skozin @ongrid