Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: async condition legacy sdk chainId #536

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: async condition legacy sdk chainId #536

wants to merge 2 commits into from

Conversation

Jeday
Copy link
Contributor

@Jeday Jeday commented Nov 6, 2024 •
edited
Loading

Description

  • prevent async race condition for legacy sdk
  • only change chainType for supported chain

Demo

Code review notes

Testing notes

Checklist:

  • Checked the changes locally.
  • Created / updated analytics events.
  • Created / updated the technical documentation (README.md / docs / etc.).
  • Affects / requires changes in other services (Matomo / Sentry / CloudFlare / etc.).

@Jeday Jeday requested review from a team as code owners November 6, 2024 08:04
@preview-stands
Copy link

preview-stands bot commented Nov 6, 2024 •
edited
Loading

Preview stand status

Preview stand available on testnet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jeday