Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 [experiment] signals unwatch (issue) v2 #118

Open
wants to merge 3 commits into
base: check-signals
Choose a base branch
from

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented May 1, 2024

PR to catch issues with signals batch unwatch

image

How to reproduce:

Open https://deploy-preview-118--g-next.netlify.app/todomvc
Add any todo item
Try to switch between Active/Completed tabs

image

Copy link

netlify bot commented May 1, 2024

Deploy Preview for g-next ready!

Name Link
🔨 Latest commit ba9d4f3
🔍 Latest deploy log https://app.netlify.com/sites/g-next/deploys/66324c6bb316ef0008972f25
😎 Deploy Preview https://deploy-preview-118--g-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lifeart lifeart changed the base branch from master to check-signals May 1, 2024 15:30
@lifeart lifeart changed the title Signals unwatch issue [experiment] signals unwatch (issue) v2 May 3, 2024
@lifeart lifeart changed the title [experiment] signals unwatch (issue) v2 🚨 [experiment] signals unwatch (issue) v2 May 21, 2024
Copy link

duration phase estimated regression +1573ms [1538ms to 1606ms] OR +53.09% [51.9% to 54.21%]
renderEnd phase no difference [0ms to 0ms]
render1000Items1End phase estimated regression +25ms [22ms to 29ms] OR +12.4% [10.89% to 14.76%]
clearItems1End phase estimated regression +15ms [13ms to 17ms] OR +79.63% [71.33% to 93.19%]
render1000Items2End phase estimated regression +39ms [33ms to 127ms] OR +25.72% [22.21% to 84.95%]
clearItems2End phase no difference [-5ms to 12ms]
render5000Items1End phase estimated regression +57ms [52ms to 61ms] OR +7.12% [6.49% to 7.74%]
clearManyItems1End phase estimated regression +93ms [91ms to 96ms] OR +102.98% [101.21% to 106.52%]
render5000Items2End phase estimated regression +269ms [259ms to 274ms] OR +38.39% [37.02% to 39.1%]
clearManyItems2End phase estimated regression +147ms [142ms to 149ms] OR +176.04% [170.88% to 179.23%]
render1000Items3End phase estimated regression +136ms [135ms to 137ms] OR +434.37% [431.39% to 437.24%]
append1000Items1End phase estimated improvement -35ms [-36ms to -20ms] OR -13.72% [-14.32% to -7.87%]
append1000Items2End phase estimated regression +74ms [70ms to 83ms] OR +44.69% [42.01% to 50.09%]
updateEvery10thItem1End phase estimated regression +78ms [69ms to 82ms] OR +78% [68.73% to 82.5%]
updateEvery10thItem2End phase estimated regression +67ms [67ms to 83ms] OR +67.28% [66.65% to 83.08%]
selectFirstRow1End phase estimated regression +70ms [67ms to 83ms] OR +211.03% [201.41% to 249.6%]
selectSecondRow1End phase estimated regression +67ms [67ms to 67ms] OR +199.87% [199.78% to 199.96%]
removeFirstRow1End phase estimated regression +67ms [67ms to 67ms] OR +133.11% [133.03% to 133.2%]
removeSecondRow1End phase estimated regression +67ms [67ms to 83ms] OR +133.98% [133.39% to 165.94%]
swapRows1End phase estimated regression +67ms [67ms to 83ms] OR +200.51% [200.19% to 249.56%]
swapRows2End phase estimated regression +77ms [67ms to 83ms] OR +229.22% [200.02% to 249.06%]
clearItems4End phase estimated regression +109ms [108ms to 110ms] OR +242.22% [239.63% to 244.15%]
paint phase estimated regression +1ms [1ms to 1ms] OR +30.28% [27.93% to 32.92%]

[14:25:14] Generating Benchmark Reports [started]
[14:25:22] Generating Benchmark Reports [completed]

Benchmark Reports    

JSON: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/compare.json

PDF: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.pdf

HTML: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant