Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[experiment] test event delegation #119

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented May 2, 2024

todo:

  • check reactivity in event arguments

Copy link

netlify bot commented May 2, 2024

Deploy Preview for g-next ready!

Name Link
🔨 Latest commit 45a340a
🔍 Latest deploy log https://app.netlify.com/sites/g-next/deploys/66374e80f5c34b000894ebc3
😎 Deploy Preview https://deploy-preview-119--g-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented May 2, 2024

duration phase estimated improvement -111ms [-160ms to -63ms] OR -0.85% [-1.23% to -0.48%]
renderEnd phase no difference [-1ms to 1ms]
render1000Items1End phase estimated improvement -7ms [-13ms to -1ms] OR -0.87% [-1.61% to -0.11%]
clearItems1End phase no difference [-3ms to 1ms]
render1000Items2End phase no difference [0ms to 1ms]
clearItems2End phase no difference [0ms to 0ms]
render5000Items1End phase estimated improvement -34ms [-50ms to -19ms] OR -1.05% [-1.54% to -0.6%]
clearManyItems1End phase estimated improvement -4ms [-14ms to -1ms] OR -0.91% [-3.19% to -0.26%]
render5000Items2End phase estimated regression +122ms [106ms to 136ms] OR +4.04% [3.52% to 4.51%]
clearManyItems2End phase estimated improvement -139ms [-219ms to -127ms] OR -25.82% [-40.54% to -23.46%]
render1000Items3End phase no difference [-11ms to 2ms]
append1000Items1End phase estimated regression +19ms [8ms to 30ms] OR +2.89% [1.28% to 4.67%]
append1000Items2End phase estimated regression +36ms [19ms to 53ms] OR +5.08% [2.68% to 7.37%]
updateEvery10thItem1End phase estimated improvement -23ms [-31ms to -14ms] OR -5.04% [-6.84% to -3.13%]
updateEvery10thItem2End phase estimated regression +16ms [8ms to 23ms] OR +3.85% [1.93% to 5.44%]
selectFirstRow1End phase estimated improvement -14ms [-16ms to -1ms] OR -10.8% [-12.03% to -0.83%]
selectSecondRow1End phase no difference [0ms to 0ms]
removeFirstRow1End phase no difference [-5ms to 0ms]
removeSecondRow1End phase estimated improvement -1ms [-16ms to 0ms] OR -0.42% [-8.52% to -0.09%]
swapRows1End phase estimated improvement -1ms [-2ms to 0ms] OR -0.48% [-1.22% to -0.14%]
swapRows2End phase estimated improvement -1ms [-15ms to 0ms] OR -0.44% [-11.61% to -0.06%]
clearItems4End phase estimated improvement -2ms [-4ms to 0ms] OR -0.96% [-1.73% to -0.06%]
paint phase no difference [0ms to 0ms]

[10:03:31] Generating Benchmark Reports [started]
[10:03:36] Generating Benchmark Reports [completed]

Benchmark Reports    

JSON: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/compare.json

PDF: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.pdf

HTML: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.html

@lifeart lifeart changed the title test event delegation [experiment] test event delegation May 3, 2024
Copy link

github-actions bot commented May 4, 2024

Code Coverage Report

Coverage after merging test-event-delegation into master

76.21%
Coverage Report
FileLines (%)Funcs (%)Uncovered Lines
.../pages/page-one
   Smile.ts77.556, 7, 8, 9, ...
.../pages/page-two
   Clock.ts94.1283.3317, 26
tests
   utils.ts95.7929, 77, 78, 79, ...
utils
   component.ts95.7978, 8, 9, 96, ...
   dom-api.ts96.8825, 39, 40, 41, ...
   dom.ts98.4890.24825, 833, 834, 905, ...
   reactive.ts91.5056, 61, 66, 67, ...
   runtime.ts95.7411, 12, 13
   shared.ts79.1396, 97, 98, 99, ...
   vm.ts24, 4
utils/benchmark
   benchmark.ts69.4419, 20, 21, 22, ...
   compat.ts96.2328, 29, 30, 38, ...
utils/control-flow
   if.ts63.125076, 77, 95, 99, ...
   list.ts93.588070, 74, 75, 76, ...
utils/helpers
   hash.ts81.8266.6714, 15, 16, 17, ...
   if.ts66.672, 3, 4
utils/inspector
   ember-inspector.ts14.70096, 97, 98, 99, ...
   index.ts33.33096, 97, 98, 99, ...
utils/ssr
   rehydration-dom-api.ts52.3896, 97, 98, 99, ...
   rehydration.ts135, 144, 34, 37, ...

@lifeart lifeart force-pushed the test-event-delegation branch from f3bdde8 to 47e13b6 Compare May 4, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant