Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 [experiment] Hash-Map based signals #153

Open
wants to merge 8 commits into
base: check-signals
Choose a base branch
from

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented May 21, 2024

sukima and others added 5 commits May 17, 2024 12:56
Prior to this change, we used the current signals polyfill which had
some performance troubles.

This change implements the signals API but uses Pzurek's monotonic
revision to handle tracking and reactivity.

This is an attempt to see if it shows performance improvements.

Paired-with: NullVoxPopulli
Copy link

github-actions bot commented May 21, 2024

duration phase no difference [-38ms to 45ms]
renderEnd phase no difference [0ms to 0ms]
render1000Items1End phase estimated regression +3ms [1ms to 11ms] OR +1.29% [0.43% to 5.68%]
clearItems1End phase no difference [-1ms to 1ms]
render1000Items2End phase estimated regression +4ms [0ms to 8ms] OR +2.6% [0.08% to 4.77%]
clearItems2End phase no difference [0ms to 0ms]
render5000Items1End phase estimated improvement -10ms [-16ms to -6ms] OR -1.26% [-1.99% to -0.69%]
clearManyItems1End phase no difference [0ms to 2ms]
render5000Items2End phase estimated regression +122ms [117ms to 132ms] OR +16.58% [15.9% to 18.02%]
clearManyItems2End phase estimated regression +46ms [44ms to 47ms] OR +39.4% [37.78% to 40.45%]
render1000Items3End phase no difference [-2ms to 3ms]
append1000Items1End phase estimated improvement -16ms [-17ms to 0ms] OR -9.7% [-10.05% to -0.06%]
append1000Items2End phase estimated improvement -45ms [-125ms to -36ms] OR -21.89% [-60.63% to -17.28%]
updateEvery10thItem1End phase estimated improvement -76ms [-84ms to -8ms] OR -53.63% [-59.63% to -5.84%]
updateEvery10thItem2End phase estimated improvement -92ms [-100ms to -72ms] OR -86.99% [-94.08% to -67.55%]
selectFirstRow1End phase no difference [0ms to 63ms]
selectSecondRow1End phase estimated improvement -12ms [-12ms to -9ms] OR -36.02% [-37.05% to -26.61%]
removeFirstRow1End phase estimated regression +11ms [4ms to 12ms] OR +22.68% [7.81% to 23.75%]
removeSecondRow1End phase no difference [0ms to 0ms]
swapRows1End phase no difference [0ms to 0ms]
swapRows2End phase no difference [0ms to 0ms]
clearItems4End phase estimated improvement -8ms [-9ms to -8ms] OR -14.08% [-15.29% to -12.76%]
paint phase estimated regression +4ms [4ms to 4ms] OR +318.69% [313.76% to 324.75%]

[20:12:14] Generating Benchmark Reports [started]
[20:12:19] Generating Benchmark Reports [completed]

Benchmark Reports    

JSON: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/compare.json

PDF: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.pdf

HTML: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants