Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: suspense api #165

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feature: suspense api #165

wants to merge 1 commit into from

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented Jun 26, 2024

Copy link

netlify bot commented Jun 26, 2024

Deploy Preview for g-next ready!

Name Link
🔨 Latest commit 33be79b
🔍 Latest deploy log https://app.netlify.com/sites/g-next/deploys/66e988e26eca7200080e9726
😎 Deploy Preview https://deploy-preview-165--g-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

duration phase no difference [-67ms to 45ms]
renderEnd phase no difference [-1ms to 1ms]
render1000Items1End phase no difference [-5ms to 5ms]
clearItems1End phase no difference [-3ms to 1ms]
render1000Items2End phase estimated regression +2ms [0ms to 16ms] OR +0.24% [0.04% to 2.38%]
clearItems2End phase no difference [0ms to 0ms]
render5000Items1End phase no difference [-6ms to 19ms]
clearManyItems1End phase no difference [-5ms to 1ms]
render5000Items2End phase no difference [-20ms to 16ms]
clearManyItems2End phase no difference [-2ms to 6ms]
render1000Items3End phase no difference [-5ms to 11ms]
append1000Items1End phase no difference [-10ms to 30ms]
append1000Items2End phase no difference [-16ms to 13ms]
updateEvery10thItem1End phase no difference [-16ms to 0ms]
updateEvery10thItem2End phase no difference [-10ms to 1ms]
selectFirstRow1End phase no difference [-1ms to 0ms]
selectSecondRow1End phase no difference [-1ms to 0ms]
removeFirstRow1End phase no difference [0ms to 0ms]
removeSecondRow1End phase no difference [0ms to 0ms]
swapRows1End phase no difference [0ms to 0ms]
swapRows2End phase no difference [0ms to 0ms]
clearItems4End phase no difference [-4ms to 0ms]
paint phase no difference [0ms to 0ms]

[22:29:21] Generating Benchmark Reports [started]
[22:29:27] Generating Benchmark Reports [completed]

Benchmark Reports    

JSON: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/compare.json

PDF: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.pdf

HTML: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.html

Copy link

github-actions bot commented Jun 27, 2024

Code Coverage Report

Coverage after merging suspencse-api into master

78.36%
Coverage Report
FileLines (%)Funcs (%)Uncovered Lines
.../pages/page-one
   Smile.ts79.596, 7, 8, 9, ...
.../pages/page-two
   Clock.ts94.1283.3317, 26
tests
   utils.ts96.1930, 87, 88, 89, ...
utils
   component.ts97.028, 80, 82, 9, ...
   dom-api.ts96.8825, 39, 40, 41, ...
   dom.ts98.7793.88938, 950, 964, 965, ...
   reactive.ts92.8897.0649, 63, 68, 69, ...
   runtime.ts93.5518, 21, 22, 23, ...
   shared.ts73, 89, 95, 98, ...
   suspense.ts54.9781.8290, 91, 92, 97, ...
   vm.ts24, 4
utils/benchmark
   benchmark.ts63.6427, 28, 29, 30, ...
   compat.ts96.2328, 29, 30, 38, ...
utils/control-flow
   if.ts72.2576.9276, 96, 97, 98, ...
   list.ts95.2985.7191, 97, 98, 99, ...
utils/helpers
   hash.ts81.8266.6714, 15, 16, 17, ...
   if.ts66.672, 3, 4
utils/inspector
   ember-inspector.ts14.70096, 97, 98, 99, ...
   index.ts33.33096, 97, 98, 99, ...
utils/ssr
   rehydration-dom-api.ts51.9996, 97, 98, 99, ...
   rehydration.ts148, 34, 37, 74, ...

@lifeart lifeart force-pushed the suspencse-api branch 2 times, most recently from 81a4578 to 7fccb6a Compare July 2, 2024 21:33
@lifeart lifeart mentioned this pull request Sep 14, 2024
80 tasks
@lifeart lifeart force-pushed the suspencse-api branch 2 times, most recently from 7c1b5c8 to 8d5c868 Compare September 17, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant