Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding helper, modifier, component helpers #85

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented Feb 2, 2024

splitting changes from #25

Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for g-next ready!

Name Link
🔨 Latest commit abda17d
🔍 Latest deploy log https://app.netlify.com/sites/g-next/deploys/65bcad86e1691200088c31b3
😎 Deploy Preview https://deploy-preview-85--g-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lifeart lifeart marked this pull request as ready for review February 2, 2024 08:54
Copy link

github-actions bot commented Feb 2, 2024

Code Coverage Report

Coverage after merging ember-composition-helpers into master

75.68%
Coverage Report
FileLines (%)Funcs (%)Uncovered Lines
.../pages/page-one
   Smile.ts71.436, 7, 8, 9, ...
.../pages/page-two
   Clock.ts94.2983.3318, 27
tests
   utils.ts95.5629, 73, 74, 75, ...
utils
   benchmark.ts69.4419, 20, 21, 22, ...
   compat.ts96.2328, 29, 30, 38, ...
   component.ts96.7079, 8, 9, 97, ...
   dom-api.ts95.6512, 21, 22, 23, ...
   dom.ts98.3492.11783, 786, 798, 877, ...
   ember-inspector.ts14.70096, 97, 98, 99, ...
   if.ts59.8366.6796, 97, 98, 99, ...
   list.ts93.388066, 70, 71, 72, ...
   reactive.ts90.5966, 67, 85, 86, ...
   rehydration-dom-api.ts5096, 97, 98, 99, ...
   rehydration.ts135, 144
   runtime.ts95.7411, 12, 13
   shared.ts76.7095, 96, 97, 98, ...
   vm.ts24, 4
utils/helpers
   hash.ts81.8266.6714, 15, 16, 17, ...
   if.ts66.672, 3, 4
utils/inspector
   index.ts33.33096, 97, 98, 99, ...

@lifeart lifeart mentioned this pull request Feb 2, 2024
22 tasks
@lifeart lifeart merged commit 78d709b into master Feb 2, 2024
8 checks passed
@lifeart lifeart deleted the ember-composition-helpers branch February 2, 2024 08:57
Copy link

github-actions bot commented Feb 2, 2024

duration phase no difference [-90ms to 192ms]
renderEnd phase no difference [-1ms to 0ms]
render1000Items1End phase no difference [-10ms to 8ms]
clearItems1End phase estimated regression +4ms [1ms to 9ms] OR +4.41% [0.79% to 9.52%]
render1000Items2End phase no difference [-16ms to 0ms]
clearItems2End phase no difference [-1ms to 0ms]
render5000Items1End phase no difference [-16ms to 50ms]
clearManyItems1End phase no difference [-3ms to 1ms]
render5000Items2End phase estimated regression +29ms [5ms to 50ms] OR +0.87% [0.14% to 1.52%]
clearManyItems2End phase no difference [-7ms to 1ms]
render1000Items3End phase estimated improvement -36ms [-69ms to -17ms] OR -5.11% [-9.9% to -2.44%]
append1000Items1End phase no difference [-3ms to 33ms]
append1000Items2End phase estimated regression +20ms [3ms to 43ms] OR +2.73% [0.42% to 5.72%]
updateEvery10thItem1End phase no difference [-1ms to 1ms]
updateEvery10thItem2End phase no difference [-14ms to 13ms]
selectFirstRow1End phase no difference [-5ms to 1ms]
selectSecondRow1End phase no difference [0ms to 0ms]
removeFirstRow1End phase no difference [0ms to 0ms]
removeSecondRow1End phase no difference [0ms to 1ms]
swapRows1End phase estimated improvement -2ms [-14ms to 0ms] OR -0.95% [-8.43% to -0.16%]
swapRows2End phase no difference [0ms to 1ms]
clearItems4End phase no difference [-5ms to 0ms]
paint phase no difference [0ms to 0ms]

[09:45:09] Generating Benchmark Reports [started]
[09:45:14] Generating Benchmark Reports [completed]

Benchmark Reports    

JSON: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/compare.json

PDF: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.pdf

HTML: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant