Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glimmer validator compat #95

Merged
merged 2 commits into from
Feb 6, 2024
Merged

glimmer validator compat #95

merged 2 commits into from
Feb 6, 2024

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented Feb 6, 2024

Copy link

netlify bot commented Feb 6, 2024

Deploy Preview for g-next ready!

Name Link
🔨 Latest commit b070315
🔍 Latest deploy log https://app.netlify.com/sites/g-next/deploys/65c2722393422300083ccfb5
😎 Deploy Preview https://deploy-preview-95--g-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Feb 6, 2024

Code Coverage Report

Coverage after merging glimmer-validator-compat into master

76.13%
Coverage Report
FileLines (%)Funcs (%)Uncovered Lines
.../pages/page-one
   Smile.ts77.556, 7, 8, 9, ...
.../pages/page-two
   Clock.ts94.1283.3317, 26
tests
   utils.ts95.5629, 73, 74, 75, ...
utils
   benchmark.ts69.4419, 20, 21, 22, ...
   compat.ts96.2328, 29, 30, 38, ...
   component.ts95.6079, 8, 9, 97, ...
   dom-api.ts95.6512, 21, 22, 23, ...
   dom.ts98.4290843, 851, 852, 922, ...
   ember-inspector.ts14.70096, 97, 98, 99, ...
   if.ts65.1266.6788, 89, 98, 99, ...
   list.ts93.508066, 70, 71, 72, ...
   reactive.ts91.4756, 61, 66, 67, ...
   rehydration-dom-api.ts48.4196, 97, 98, 99, ...
   rehydration.ts135, 144, 34, 37, ...
   runtime.ts95.7411, 12, 13
   shared.ts76.7095, 96, 97, 98, ...
   vm.ts24, 4
utils/helpers
   hash.ts81.8266.6714, 15, 16, 17, ...
   if.ts66.672, 3, 4
utils/inspector
   index.ts33.33096, 97, 98, 99, ...

@lifeart lifeart mentioned this pull request Feb 6, 2024
14 tasks
@lifeart lifeart marked this pull request as ready for review February 6, 2024 17:54
Copy link

github-actions bot commented Feb 6, 2024

duration phase no difference [-119ms to 281ms]
renderEnd phase no difference [-1ms to 0ms]
render1000Items1End phase no difference [-11ms to 12ms]
clearItems1End phase no difference [-3ms to 6ms]
render1000Items2End phase no difference [-1ms to 16ms]
clearItems2End phase no difference [0ms to 1ms]
render5000Items1End phase no difference [-23ms to 66ms]
clearManyItems1End phase no difference [-3ms to 6ms]
render5000Items2End phase no difference [-20ms to 52ms]
clearManyItems2End phase no difference [-3ms to 7ms]
render1000Items3End phase no difference [-19ms to 16ms]
append1000Items1End phase no difference [-16ms to 25ms]
append1000Items2End phase no difference [-13ms to 33ms]
updateEvery10thItem1End phase no difference [-1ms to 4ms]
updateEvery10thItem2End phase no difference [-28ms to 1ms]
selectFirstRow1End phase no difference [-1ms to 5ms]
selectSecondRow1End phase no difference [0ms to 0ms]
removeFirstRow1End phase no difference [-1ms to 0ms]
removeSecondRow1End phase no difference [0ms to 1ms]
swapRows1End phase no difference [-2ms to 2ms]
swapRows2End phase no difference [-1ms to 0ms]
clearItems4End phase no difference [-2ms to 5ms]
paint phase no difference [0ms to 0ms]

[19:47:53] Generating Benchmark Reports [started]
[19:47:58] Generating Benchmark Reports [completed]

Benchmark Reports    

JSON: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/compare.json

PDF: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.pdf

HTML: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.html

@lifeart lifeart merged commit dd184fb into master Feb 6, 2024
8 checks passed
@lifeart lifeart deleted the glimmer-validator-compat branch February 6, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant