LPD-64708 - Stop loading external resources #5068
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is automatically triggering the following test suites:
|
|
Test suite sf has been triggered on http://test-1-29 |
liferay-continuous-integration
added
ci:test:sf - pending
ci:test:sf - success
and removed
ci:test:sf - pending
labels
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutesRan com.liferay.source.formatter at released version 1.0.1534. Click here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-64708 1 Successful Jobs:For more details click here. |
|
Jenkins Build:test-portal-source-format#7295 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#5068 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - bryceosterhaus > liferay-frontend - PR#5068 - 2025-09-04[23:23:21] Testray Build ID: 309301090Testray Importer:test-portal-source-format#7295 |
@bryceosterhaus When is this happening? just on script loading/import? where are they requested? Is the change you made here altering the way those external resources are loaded? |
|
They are requested from the JS that runs, but we don't package the images, so we just need to add them in the build process I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://liferay.atlassian.net/browse/LPD-64708
So leaflet internally requests some image assets to load on the map, we need to figure out how to configure that and if we should add a "file-loader" to our build process for static assets