LPD-24670 | Inform about Data Sets without visualization mode when selecting Data Set #5122

chestofwonders · 2025-10-10T10:20:12Z

Issue: https://liferay.atlassian.net/browse/LPD-24670

See #5110 for previous discussion

Inform about Data Sets without visualization mode when selecting Data Set

The goal of this PR is to warn the user when selecting a Data Set from the list to display in a fragment, that there are Data Set that will not be able to be displayed on the page, since no visualization modes have been defined for them.

Also, a tooltip is show when user hovers the cursor over the warning icon

liferay-continuous-integration · 2025-10-10T10:20:18Z

CI is automatically triggering the following test suites:

ci:test:sf

liferay-continuous-integration · 2025-10-10T10:20:20Z

Test suite sf has been triggered on http://test-1-38

liferay-continuous-integration · 2025-10-10T10:24:02Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Ran com.liferay.source.formatter at released version 1.0.1543.
*The latest version has not been released.

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 4a7943d4bb3c08c4d0ea8f2359b17a0c50f7a371

Sender Branch:

Branch Name: LPD-24670
Branch GIT ID: df578cfdcec8619ed6559bb3abd48012678939d8

1 out of 1 jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2025-10-10T10:24:21Z

Jenkins Build:test-portal-source-format#6642

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-frontend#5122

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - chestofwonders > liferay-frontend - PR#5122 - 2025-10-10[03:20:25]

Testray Build ID:336937551

Testray Importer:test-portal-source-format#6642

dsanz · 2025-10-10T11:24:15Z

@chestofwonders pls check comment on old, draft PR

Also, pls remove "WIP" from commit message :)

dsanz

@chestofwonders pls see inline comments

...les/apps/portal-language/portal-language-lang/src/main/resources/content/Language.properties

...a-set-admin-web/src/main/resources/META-INF/resources/item/selector/FDSAdminItemSelector.tsx

...end-data-set/frontend-data-set-web/src/main/resources/META-INF/resources/views/list/List.tsx

kresimir-coko

small nit

...end-data-set/frontend-data-set-web/src/main/resources/META-INF/resources/views/list/List.tsx

markocikos

@chestofwonders please see comments inline

...a-set-admin-web/src/main/resources/META-INF/resources/item/selector/FDSAdminItemSelector.tsx

...end-data-set/frontend-data-set-web/src/main/resources/META-INF/resources/views/list/List.tsx

…cting Data Set

dsanz

LGTM ;) pls see inline comments. Just minor nit on test description

dsanz · 2025-10-29T18:29:21Z

...a-set-admin-web/src/main/resources/META-INF/resources/item/selector/FDSAdminItemSelector.tsx

+			sticker: 'sticker',
 			symbol: 'symbol',
 			title: 'label',
+			tooltip: 'tooltip',


Now that List.tsx handles everything via schema we don't need hidden conventions in order to pass the information we need ✨

dsanz · 2025-10-29T18:31:04Z

...end-data-set/frontend-data-set-web/src/main/resources/META-INF/resources/views/list/List.tsx

+											<ClayIcon symbol={item[symbol]} />
+										</ClaySticker>
+									</span>
+								</ClayTooltipProvider>


we are rendering the tooltip, if present, associated woth the symbol. This is as opinionated as doing it in other places. Decision follows designs, it's fine. In the future, placement of tooltip can be changed/tweaked if needed 👍

dsanz · 2025-10-29T18:32:20Z

...end-data-set/frontend-data-set-web/src/main/resources/META-INF/resources/views/list/List.tsx

-				<ClayList.ItemField>
-					{(itemsActions || item.actionDropdownItems) && (
+				{(itemsActions || item.actionDropdownItems) && (
+					<ClayList.ItemField>


nice catch avoiding an empty ItemField component here when there are no actions

dsanz · 2025-10-29T18:34:30Z

...a-set-admin-web/src/main/resources/META-INF/resources/item/selector/FDSAdminItemSelector.tsx

+						symbol: 'exclamation-circle',
+						tooltip: Liferay.Language.get(
+							'no-visualization-modes-have-been-defined'
+						),


🚀 With this change, now the concept of "valid" is meaningless for FDS, which limits itself to render what's told to. Parent component here is in charge of defining the intent of the item depending on custom conditions.

This is the right pattern!

...t/playwright/tests/frontend-data-set-admin-web/main/tests/data-set-fragment/dataSets.spec.ts

chestofwonders · 2025-10-29T19:21:40Z

ci:forward

liferay-continuous-integration · 2025-10-29T19:21:46Z

Test suite relevant has been triggered on http://test-1-32

liferay-continuous-integration · 2025-10-29T19:21:48Z

Test suite sf has been triggered on http://test-1-32

liferay-continuous-integration · 2025-10-29T19:21:49Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf
ci:test:stable

The pull request will automatically be forwarded to the user brianchandotcom If the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2025-10-29T19:26:06Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Ran com.liferay.source.formatter at released version 1.0.1548.

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 375f6214ece954953627aa16f77a1de631884743

Sender Branch:

Branch Name: LPD-24670
Branch GIT ID: 29c5f256151b9a914f5f61fa7a84e636f3bf94e8

1 out of 1 jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2025-10-29T19:26:23Z

Jenkins Build:test-portal-source-format#11181

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-frontend#5122

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - chestofwonders > liferay-frontend - PR#5122 - 2025-10-29[12:21:53]

Testray Build ID:353962452

Testray Importer:test-portal-source-format#11181

liferay-continuous-integration · 2025-10-29T20:20:02Z

✔️ ci:test:stable - 11 out of 11 jobs passed

❌ ci:test:relevant - 14 out of 17 jobs passed in 58 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 375f6214ece954953627aa16f77a1de631884743

Upstream Comparison:

Branch GIT ID: cb2950353b3968cfa6c10a0bd3dfebb8e8beafc3
Jenkins Build URL: EE Development Acceptance (master) - 196 - 2025-10-16[16:39:16]

ci:test:stable - 11 out of 11 jobs PASSED

11 Successful Jobs:

ci:test:relevant - 14 out of 17 jobs PASSED

3 Failed Jobs:

~~test-portal-acceptance-pullrequest(master)~~
functional-upgrade-tomcat101-postgresql163_stable
js-unit
modules-integration-postgresql163
- modules-integration-postgresql163/0/0
modules-integration-postgresql163_stable
- modules-integration-postgresql163_stable/0/0
modules-semantic-versioning
- modules-semantic-versioning/0/0
playwright-js-tomcat101-mysql84
playwright-js-tomcat101-postgresql163_stable
- playwright-js-tomcat101-postgresql163_stable/0/0
unit_stable
- unit_stable/0/0

14 Successful Jobs:

For more details click here.

Failures unique to this pull:

For upstream results, click here.

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz

liferay-continuous-integration · 2025-10-29T20:21:52Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#8583

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-frontend#5122

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - chestofwonders > liferay-frontend - PR#5122 - 2025-10-29[12:21:53]

Testray Build ID:354045632

Testray Importer:test-portal-acceptance-pullrequest(master)#8583

chestofwonders · 2025-10-30T10:01:27Z

ci:forward:force

liferay-continuous-integration · 2025-10-30T10:01:31Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf
ci:test:stable

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites complete:

ci:test:relevant
ci:test:sf
AND If the following test suites pass:
ci:test:stable

liferay-continuous-integration · 2025-10-30T10:01:32Z

Skipping previously completed test suites:

ci:test:relevant
ci:test:sf
AND Skipping previously passed test suites:
ci:test:stable

liferay-continuous-integration · 2025-10-30T10:01:34Z

Test suite default has been triggered on http://test-1-32

liferay-continuous-integration · 2025-10-30T10:02:13Z

All required test suite(s) completed.
Forwarding pull request to brianchandotcom.
Console

liferay-continuous-integration · 2025-10-30T10:02:39Z

Pull request has been successfully forwarded to brianchandotcom#167224
Console

chestofwonders requested a review from liferay-frontend as a code owner October 10, 2025 10:20

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Oct 10, 2025

chestofwonders added the 🛑 Missing Tests label Oct 10, 2025

chestofwonders requested review from dsanz, juanjofgliferay and markocikos and removed request for liferay-frontend October 10, 2025 10:27

dsanz mentioned this pull request Oct 10, 2025

LPD-24670 WIP. #5110

Closed

chestofwonders force-pushed the LPD-24670 branch 3 times, most recently from f4b4fa6 to db9686f Compare October 20, 2025 15:59

dsanz requested changes Oct 20, 2025

View reviewed changes

chestofwonders force-pushed the LPD-24670 branch 2 times, most recently from 6f9d530 to 501b5fa Compare October 21, 2025 09:21

chestofwonders removed the 🛑 Missing Tests label Oct 21, 2025

chestofwonders requested a review from dsanz October 21, 2025 09:23

chestofwonders force-pushed the LPD-24670 branch 2 times, most recently from c549eca to 1a6c46b Compare October 21, 2025 11:04

kresimir-coko reviewed Oct 27, 2025

View reviewed changes

...end-data-set/frontend-data-set-web/src/main/resources/META-INF/resources/views/list/List.tsx Outdated Show resolved Hide resolved

markocikos requested changes Oct 27, 2025

View reviewed changes

LPD-24670 Inform about Data Sets without visualization mode when sele…

94dbed1

…cting Data Set

chestofwonders force-pushed the LPD-24670 branch from 1a6c46b to 2f72fb2 Compare October 29, 2025 11:29

chestofwonders requested a review from herrardo October 29, 2025 11:32

dsanz approved these changes Oct 29, 2025

View reviewed changes

LPD-24670 Test Automation

29c5f25

chestofwonders force-pushed the LPD-24670 branch from 2f72fb2 to 29c5f25 Compare October 29, 2025 19:20

liferay-continuous-integration added ci:test:sf - pending ci:test:relevant - pending ci:test:stable - pending ci:test:sf - success and removed ci:test:sf - success ci:test:sf - pending labels Oct 29, 2025

liferay-continuous-integration added ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Oct 29, 2025

liferay-continuous-integration mentioned this pull request Oct 30, 2025

LPD-24670 | Inform about Data Sets without visualization mode when selecting Data Set brianchandotcom/liferay-portal#167224

Closed

liferay-continuous-integration added the ci:forward:force label Oct 30, 2025

liferay-continuous-integration closed this Oct 30, 2025

LPD-24670 | Inform about Data Sets without visualization mode when selecting Data Set #5122

LPD-24670 | Inform about Data Sets without visualization mode when selecting Data Set #5122

Uh oh!

Conversation

chestofwonders commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Inform about Data Sets without visualization mode when selecting Data Set

Uh oh!

liferay-continuous-integration commented Oct 10, 2025

Uh oh!

liferay-continuous-integration commented Oct 10, 2025

Uh oh!

liferay-continuous-integration commented Oct 10, 2025

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Base Branch:

Sender Branch:

For more details click here.

Uh oh!

liferay-continuous-integration commented Oct 10, 2025

Uh oh!

dsanz commented Oct 10, 2025

Uh oh!

dsanz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kresimir-coko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

markocikos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dsanz left a comment

Choose a reason for hiding this comment

Uh oh!

dsanz Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

dsanz Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

dsanz Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

dsanz Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chestofwonders commented Oct 29, 2025

Uh oh!

liferay-continuous-integration commented Oct 29, 2025

Uh oh!

liferay-continuous-integration commented Oct 29, 2025

Uh oh!

liferay-continuous-integration commented Oct 29, 2025

Uh oh!

liferay-continuous-integration commented Oct 29, 2025

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Base Branch:

Sender Branch:

For more details click here.

Uh oh!

liferay-continuous-integration commented Oct 29, 2025

Uh oh!

liferay-continuous-integration commented Oct 29, 2025

✔️ ci:test:stable - 11 out of 11 jobs passed

❌ ci:test:relevant - 14 out of 17 jobs passed in 58 minutes

chestofwonders commented Oct 10, 2025 •

edited

Loading