Skip to content

LPD-68333 Compute default theme URLs inside ThemeDisplay #5123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

LPD-68333 Compute default theme URLs inside ThemeDisplay #5123

wants to merge 3 commits into from
+31 −164

Conversation

izaera
Copy link
Collaborator

@izaera izaera commented Oct 13, 2025

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

Test suite sf has been triggered on http://test-1-25

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:sf - 0 out of 1 jobs passed in 3 minutes

Ran com.liferay.source.formatter at released version 1.0.1543.
*The latest version has not been released.

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 9e3ec14bde062e2f485871e12579fad1e61a468f

Sender Branch:

Branch Name: LPD-68333
Branch GIT ID: f6422f10938148b76e5ffd56bc29ed15ed695307

0 out of 1 jobs PASSED
For more details click here.
format-source-files:
     [java] java.lang.Exception: Found 5 formatting issues:
     [java] 1: '?' should be on the previous line., see https://checkstyle.sourceforge.io/checks/whitespace/operatorwrap.html: ./portal-kernel/src/com/liferay/portal/kernel/theme/ThemeDisplay.java 199 (Checkstyle:OperatorWrapCheck)
     [java] 2: ':' should be on the previous line., see https://checkstyle.sourceforge.io/checks/whitespace/operatorwrap.html: ./portal-kernel/src/com/liferay/portal/kernel/theme/ThemeDisplay.java 200 (Checkstyle:OperatorWrapCheck)
     [java] 3: '?' should be on the previous line., see https://checkstyle.sourceforge.io/checks/whitespace/operatorwrap.html: ./portal-kernel/src/com/liferay/portal/kernel/theme/ThemeDisplay.java 581 (Checkstyle:OperatorWrapCheck)
     [java] 4: ':' should be on the previous line., see https://checkstyle.sourceforge.io/checks/whitespace/operatorwrap.html: ./portal-kernel/src/com/liferay/portal/kernel/theme/ThemeDisplay.java 582 (Checkstyle:OperatorWrapCheck)
     [java] 5: Truncated message :
     [java] ./portal-kernel/src/com/liferay/portal/kernel/theme/ThemeDisplay.java expected:<..._httpServletRequest)[ ?
     [java]           "/clay_rtl.css" : "/clay.css"));
     [java] 
     [java]     if (Validator.isNotNull(hashedFileURI)) \{
     [java]       _clayCSSURL = hashedFileURI;
     [java]     \}
     [java]     else \{
     [java]       _clayCSSURL = PortalUtil.getStaticResourceURL(
     [java]         getRequest(), getPathThemeCss() + "/clay.css");
     [java]     \}
     [java] 
     [java]     return _clayCSSURL;
     [java]   \}
     [java] 
     [java]   public ColorScheme getColorScheme() \{
     [java]     return _colorScheme;
     [java]   \}
     [java] 
     [java]   /**
     [java]    * Returns the color scheme ID as defined in the theme's
     [java]    * <code>liferay-look-and-feel.xml</code>.
     [java]    *
     [java]    * @return the color scheme ID as defined in the theme's
     [java]    *         <code>liferay-look-and-feel.xml</code>
     [java]    */
     [java]   public String getColorSchemeId() \{
     [java]     return _colorScheme.getColorSchemeId();
     [java]   \}
     [java] 
     [java]   /**
     [java]    * Returns the portal instance bean.
     [java]    *
     [java]    * <p>
     [java]    * Company is Liferay's technical name for a portal instance.
     [java]    * <p>
     [java]    *
     [java]    * @return the portal instance bean
     [java]    */
     [java]   public Company getCompany() \{
     [java]     return _company;

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Report:jenkins-report.html
Jenkins Suite:sf
Testray Routine:EE Pull Request
Testray Build ID:338325718

@izaera
Copy link
Collaborator Author

izaera commented Oct 13, 2025

ci:test:platform-experience

@liferay-continuous-integration
Copy link
Collaborator

Test suite platform-experience has been triggered on http://test-1-37

@izaera
Copy link
Collaborator Author

izaera commented Oct 13, 2025

ci:test:sf

@izaera
Copy link
Collaborator Author

izaera commented Oct 13, 2025

ci:test:platform-experience

@liferay-continuous-integration
Copy link
Collaborator

Test suite sf has been triggered on http://test-1-37

@liferay-continuous-integration
Copy link
Collaborator

Test suite platform-experience has been triggered on http://test-1-37

@izaera
Copy link
Collaborator Author

izaera commented Oct 13, 2025

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

Test suite relevant has been triggered on http://test-1-37

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Ran com.liferay.source.formatter at released version 1.0.1543.
*The latest version has not been released.

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 9e3ec14bde062e2f485871e12579fad1e61a468f

Sender Branch:

Branch Name: LPD-68333
Branch GIT ID: 3e4ad7912ffb200aaebc8d8baab7bd2722955f6b

1 out of 1 jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 12 out of 12 jobs passed

❌ ci:test:relevant - 23 out of 53 jobs passed in 3 hours 27 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 8464f00bcc283efc8676dcf701ee1a41091d15e2

Upstream Comparison:

Branch GIT ID: 88175d6f657b94f7ec9c84c23db094335bee7a6c
Jenkins Build URL: EE Development Acceptance (master) - 190 - 2025-10-14[16:37:28]

ci:test:stable - 12 out of 12 jobs PASSED
12 Successful Jobs:
    ci:test:relevant - 23 out of 53 jobs PASSED

    30 Failed Jobs:

    23 Successful Jobs:
      For more details click here.

      Failures unique to this pull:

      6. ...

      For upstream results, click here.

      Test bundle downloads:

      @liferay-continuous-integration
      Copy link
      Collaborator

      @izaera
      Copy link
      Collaborator Author

      izaera commented Oct 17, 2025

      ci:report:341865643

      @liferay-continuous-integration
      Copy link
      Collaborator

      Test suite default has been triggered on http://test-1-36

      @liferay-continuous-integration
      Copy link
      Collaborator

      Build completed.

      Job Link: generate-testray-csv

      Unable to generate report for testrayBuildID: 341865643.

      Please verify the testrayBuildID is correct, there are failures, and the respective testray build has results imported. If the results are not imported, rerun ci:report:341865643 in 10-30 minutes.

      @izaera
      Copy link
      Collaborator Author

      izaera commented Oct 20, 2025

      ci:report:341865643

      @liferay-continuous-integration
      Copy link
      Collaborator

      Test suite default has been triggered on http://test-1-35

      @liferay-continuous-integration
      Copy link
      Collaborator

      Build completed.

      Testray CSV has been generated successfully for testrayBuildID: 341865643.

      Job Link: generate-testray-csv

      Testray CSV Link: testray-results-341865643.csv

      @izaera
      Copy link
      Collaborator Author

      izaera commented Oct 20, 2025

      Failing tests have been fixed 🎉

      @izaera
      Copy link
      Collaborator Author

      izaera commented Oct 20, 2025

      ci:forward:force

      @liferay-continuous-integration
      Copy link
      Collaborator

      CI is automatically triggering the following test suites:

      •     ci:test:relevant
      •     ci:test:sf
      •     ci:test:stable

      The pull request will automatically be forwarded to the user brianchandotcom if the following test suites complete:

      •     ci:test:relevant
      •     ci:test:sf
        AND If the following test suites pass:
      •     ci:test:stable

      @liferay-continuous-integration
      Copy link
      Collaborator

      Skipping previously completed test suites:

      • ci:test:relevant
      • ci:test:sf
        AND Skipping previously passed test suites:
      • ci:test:stable

      @liferay-continuous-integration
      Copy link
      Collaborator

      Test suite default has been triggered on http://test-1-31

      @liferay-continuous-integration
      Copy link
      Collaborator

      All required test suite(s) completed.
      Forwarding pull request to brianchandotcom.
      Console

      Open
      @liferay-continuous-integration
      Copy link
      Collaborator

      Pull request has been successfully forwarded to brianchandotcom#166804
      Console

      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

      Reviewers

      @dsanz dsanz dsanz approved these changes

      @liferay-frontend liferay-frontend Awaiting requested review from liferay-frontend liferay-frontend is a code owner

      Assignees

      No one assigned

      Labels

      ci:forward:force ci:test - success ci:test:platform-experience - failure ci:test:relevant - failure ci:test:sf - success ci:test:stable - success

      Projects

      None yet

      Milestone

      No milestone

      Development

      Successfully merging this pull request may close these issues.

      3 participants

      @izaera @liferay-continuous-integration @dsanz