Lpd 67267 rework #5139
Closed
Lpd 67267 rework #5139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is automatically triggering the following test suites:
|
|
Test suite sf has been triggered on http://test-1-26 |
❌ ci:test:sf - 0 out of 1 jobs passed in 47 secondsRan com.liferay.source.formatter at released version 1.0.1544. Click here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-67267-rework 1 Failed Jobs:For more details click here.Please fix rebase errors on izaera/LPD-67267-rework Unable to rebase master-temp-1760695883690 to master Rebasing (1/4) Rebasing (2/4) error: could not apply 8c88f7d7ae0a4... WIP |
This is a way to tell TypeScript where to get the types for CKEditor split packages. Another option would be using bare identifiers in source code (for example: `@ckeditor/ckeditor5-core` instead of `@ckeditor/ckeditor5-core/dist/index.js`, then configuring aliases to rewrite imports from `@ckeditor/ckeditor5-core` to `@ckeditor/ckeditor5-core/dist/index.js`. It seems to me that the `types.d.ts` option is easier to maintain and also clearer since what you see in code is what you get at runtime. In the end, it's a TypeScript problem that has nothing to do with code and bundling so it wouldn't be fair to affect those two.
izaera
force-pushed
the
LPD-67267-rework
branch
from
813814e to
ff61e12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.