Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@clayui/css): LPD-46381 form-control-select-secondary should only… #5919

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pat270
Copy link
Member

@pat270 pat270 commented Jan 17, 2025

… be as wide as its contents

https://liferay.atlassian.net/browse/LPD-46381

@matuzalemsteles
Copy link
Member

Hey @pat270 I think this affects the Picker for width cases, for example see the difference in the master: https://storybook.clayui.com/?path=/story/design-system-components-picker--width and with the changes of this PR: https://deploy-preview-5919--next-storybook-clayui.netlify.app/?path=/story/design-system-components-picker--width.

I think we want to keep it as it is in the master because we can have the size of the picker taking up all the space regardless of the content inside the trigger.

@pat270
Copy link
Member Author

pat270 commented Jan 23, 2025

@matuzalemsteles sounds good. Can we make the default min-content in Picker? I'll create another ticket for the color discrepancies between clay and cadmin.

@pat270
Copy link
Member Author

pat270 commented Jan 23, 2025

@matuzalemsteles I looked at this more and how about we add a helper class like form-control-select-shrink? That way we don't break users who are using the width method.

@matuzalemsteles
Copy link
Member

I looked at this more and how about we add a helper class like form-control-select-shrink? That way we don't break users who are using the width method.

@pat270 well it may be but I'm not sure if it will help some people, because the dev can wrap the Picker in a container and control its size but this can be a good utility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants