Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed getEntry method call in deleteEntry method impl #528

Open
wants to merge 1 commit into
base: 7.1.x
Choose a base branch
from
Open

removed getEntry method call in deleteEntry method impl #528

wants to merge 1 commit into from

Commits on Jul 23, 2019

  1. removed getEntry method call in deleteEntry method impl 

    Both getEntry(entryId) and deleteEntry(entryId) return the entity by its ID or throw a PortalException
if the entity with the provided Id does not exists in the persistence layer. So, the first call is redundant.
The method implementation could have been simplified to one-line: return deleteEntry(entryId), but
I keep the assigment to make it more clear that deleteEntry() method is returning the Entry.
    @dgomezg
    dgomezg committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    7749de6 View commit details
    Browse the repository at this point in the history