Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query Limits Management Feature #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Query Limits Management Feature #7
Changes from 7 commits
44476c6
48c4d77
4ddfa12
9506cd7
8937e0c
53fdce7
fc344cc
f58a46e
506de16
2871915
b259224
e2925dc
fc00b67
f346e43
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if this needs to be a separate column, or if it would work (and be a bit simpler) to just have a query_limit column that's either an integer (when there is a limit active) or NULL when there is no limit in a class. I'm leaning toward the simpler design, unless there's a reason I'm not seeing to have two columns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the simpler design would definitely work. We would just need to modify a few SQL statements that are looking for this column to check if the query_limit is either NULL or an integer. And of course, set the value accordingly when the instructor either enables or disables this feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is just tied to the user, then it won't work correctly for users in multiple classes, right? I think this might need a different design.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I did not realize that a student account could be in multiple classes. Will need to rethink this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generating HTML in the SQL statement is an overly-complex way to accomplish this. I think using the
actions
list in the DataTable can handle this in a much simpler way. Let me know if that doesn't work here for some reason.