Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/adopt core commons #540

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

Feature/adopt core commons #540

wants to merge 14 commits into from

Conversation

alo3y
Copy link
Collaborator

@alo3y alo3y commented Dec 14, 2021

  • Adopts core commons to lifion-kinesis
  • Update eslint rules
  • Fix tests
  • Update typings for full coverage

@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #540 (8886562) into develop (6fb394b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #540   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines         1398      1409   +11     
  Branches       190       203   +13     
=========================================
+ Hits          1398      1409   +11     
Impacted Files Coverage Δ
lib/deaggregate.js 100.00% <ø> (ø)
lib/dynamodb-client.js 100.00% <ø> (ø)
lib/s3-client.js 100.00% <ø> (ø)
lib/utils.js 100.00% <ø> (ø)
lib/bucket.js 100.00% <100.00%> (ø)
lib/compression.js 100.00% <100.00%> (ø)
lib/consumers-manager.js 100.00% <100.00%> (ø)
lib/fan-out-consumer.js 100.00% <100.00%> (ø)
lib/heartbeat-manager.js 100.00% <100.00%> (ø)
lib/index.js 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fb394b...8886562. Read the comment docs.

@alo3y alo3y changed the title [WIP] Feature/adopt core commons Feature/adopt core commons Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant