Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): add bun.lock support #238

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

fmorency
Copy link
Contributor

@fmorency fmorency commented Feb 5, 2025

This PR adds support for bun.lock during the Docker image creation. This PR also bumps the container build environment.

Summary by CodeRabbit

  • Chores
    • Upgraded the container build environment to a newer, more stable version.
    • Enhanced the system's flexibility for managing dependency locks during installation and build processes.

@fmorency fmorency added the bug Something isn't working label Feb 5, 2025
@fmorency fmorency self-assigned this Feb 5, 2025
Copy link
Contributor

coderabbitai bot commented Feb 5, 2025

Walkthrough

The Dockerfile has been updated to use a newer base image version and modified its handling of lockfiles. The updates now copy bun.lock instead of bun.lockb, and conditional checks during dependency installation and build steps have been adjusted to accept either bun.lockb or bun.lock. This ensures that the build process can proceed if either of the lockfiles is present.

Changes

File Change Summary
Dockerfile - Updated base image from oven/bun:1.1.34-slim to oven/bun:1.2-slim
- Modified COPY command to include bun.lock instead of bun.lockb
- Adjusted conditional checks to consider either bun.lockb or bun.lock for dependency installation and build commands

Sequence Diagram(s)

sequenceDiagram
    participant Builder as Docker Builder
    participant LockChecker as Lockfile Checker
    participant Installer as Dependency Installer
    participant BuildRunner as Build Executor

    Builder->>LockChecker: Check for bun.lockb or bun.lock
    alt Lockfile exists
        LockChecker-->>Builder: Lockfile found
        Builder->>Installer: Execute "bun install --no-save"
        Builder->>BuildRunner: Execute "bun run build"
    else
        LockChecker-->>Builder: No lockfile found
        Builder-->>Builder: Proceed without lock-dependent actions
    end
Loading

Poem

I'm a little rabbit, leaping through the code,
Hop, hop in Docker towers where updates now explode.
A new base image shines, and lockfiles join the tune,
Skipping 'bun.lockb' troubles under a newer moon.
With each build command, a joyful hop I send—
Celebrating changes in a code garden without end! 🐇✨

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 45ae9ba and bc099ba.

📒 Files selected for processing (1)
  • Dockerfile (2 hunks)
🔇 Additional comments (4)
Dockerfile (4)

3-3: Base Image Version Update

The base image has been updated to use oven/bun:1.2-slim, which aligns with the intended upgrade. Please ensure that this new image version has been tested in your target environments.


10-10: Inclusion of Bun Lockfiles in COPY Command

The COPY command now uses the wildcard bun.lock* to capture either bun.lock or bun.lockb. This improves flexibility by ensuring that whichever lockfile is present will be copied.

Ensure that the wildcard does not unintentionally match any other files.


15-15: Enhanced Dependency Installation Check for Bun

The dependency installation step now conditionally checks for either bun.lockb or bun.lock before running bun install --no-save. This change adheres to the updated support for multiple lockfile names.


38-38: Enhanced Build Command Condition for Bun

The build command section has been updated to check for either bun.lockb or bun.lock before running bun run build. This ensures that the build process will execute correctly when either file is present.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.08%. Comparing base (45ae9ba) to head (bc099ba).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #238   +/-   ##
=======================================
  Coverage   55.08%   55.08%           
=======================================
  Files         200      200           
  Lines       16873    16873           
=======================================
  Hits         9294     9294           
  Misses       7579     7579           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fmorency fmorency merged commit 8af1d4e into liftedinit:main Feb 5, 2025
4 checks passed
@fmorency fmorency deleted the fix-bun branch February 5, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant