Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add new env var to docker #251

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

fmorency
Copy link
Contributor

@fmorency fmorency commented Feb 6, 2025

This PR adds the new env. var introduced in #194 to the .env file generated during the Docker image creation.

Summary by CodeRabbit

  • New Features
    • Expanded support for Osmosis and Axelar networks with enhanced configuration options for improved connectivity and integration.

@fmorency fmorency added the bug Something isn't working label Feb 6, 2025
@fmorency fmorency self-assigned this Feb 6, 2025
Copy link
Contributor

coderabbitai bot commented Feb 6, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request updates the GitHub Actions workflow for Docker image builds by appending several new environment variables. These variables, which pertain to Osmosis and Axelar networks, are set during the creation of the .env file using echo commands. The process pulls configuration values from designated vars and secrets contexts, ensuring the Docker build process uses the correct network settings. No modifications were made to any exported or public entities.

Changes

File Change Summary
.github/workflows/docker.yml Appended new environment variables for Osmosis and Axelar networks to the .env file using echo commands.

Sequence Diagram(s)

sequenceDiagram
    participant GA as GitHub Actions
    participant Env as .env File
    participant Sec as Secrets/Vars
    participant Docker as Docker Build Process

    GA->>Sec: Retrieve Osmosis & Axelar variables
    GA->>Env: Append variables via echo
    Env->>Docker: Supply configuration
    Docker->>GA: Build image with updated settings
Loading

Possibly related PRs

  • ci: docker testnet #58: Involved similar modifications to the .env file and configuration steps in the Docker workflow.

Suggested labels

enhancement

Suggested reviewers

  • jgryffindor
  • chalabi2

Poem

I'm a bunny, soft and spry,
Tweaking configs as time flies by.
New env vars hop into the fray,
Guiding Docker all the way.
With a twitch of my ear, a joyful cheer—
CodeRabbit delights in changes here! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 64be274 and 324697b.

📒 Files selected for processing (1)
  • .github/workflows/docker.yml (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@fmorency fmorency merged commit 244c1e6 into liftedinit:main Feb 6, 2025
2 checks passed
@fmorency fmorency deleted the fix-ci-docker branch February 6, 2025 21:30
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.02%. Comparing base (64be274) to head (324697b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #251   +/-   ##
=======================================
  Coverage   55.02%   55.02%           
=======================================
  Files         204      204           
  Lines       17636    17636           
=======================================
  Hits         9704     9704           
  Misses       7932     7932           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant