-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 1Password from all our input texts #254
Conversation
There might be a place where we want 1Password to allow for showing the autofill dialog, but any place I found that was showing it it was more annoying. For example, it shows over the Contact button in the Address input, because it wants to fill it with my street address.
WalkthroughThis update in the TextInput component adjusts the rendering of the BaseInput element. The component now includes an additional attribute, data-1p-ignore, alongside the previously spread props. No changes were made to exported or public entities. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #254 +/- ##
=======================================
Coverage 55.02% 55.02%
=======================================
Files 204 204
Lines 17636 17636
=======================================
Hits 9704 9704
Misses 7932 7932 ☔ View full report in Codecov by Sentry. |
There might be a place where we want 1Password to allow for showing the autofill dialog, but any place I found that was showing it it was more annoying.
For example, it shows over the Contact button in the Address input, because it wants to fill it with my street address.
Example:
Summary by CodeRabbit