fix: payout send handler

[fmorency]

This PR fixes the address display of the MsgPayout handler.

Summary by CodeRabbit

• Refactor
  • Improved the display formatting for recipient addresses. The updated presentation now delivers a clearer and more consistent view, ensuring that address details remain easy to read across various scenarios without altering the existing functionality.

[coderabbitai]

Walkthrough

This PR refactors the logic within the createSendMessage function in the msgPayoutHandler.tsx file. The nested ternary operator used for constructing the recipient string has been replaced with a structured JSX expression that employs React fragments to wrap the TruncatedAddressWithCopy component. The updated code maintains the same conditional checks based on the number of addresses in the pairs array, without altering the parameters, return types, or overall function structure.

Changes

File	Change Summary
components/bank/handlers/manifest/msgPayoutHandler.tsx	Refactored createSendMessage to replace nested ternary string concatenation with JSX fragments wrapping the TruncatedAddressWithCopy component.

Possibly related PRs

• fix: tx history improvements #229: Modifications to the createSendMessage function in this PR have a direct connection to the changes in that PR.

Suggested labels

render

Suggested reviewers

• chalabi2

Poem

I'm a happy rabbit, hopping with glee,
Seeing tidy JSX code sets my heart free.
No more tangled ternaries to confuse my day—
Clean fragments guide my hops along the way!
With every neat change, I cheer and delight,
Coding carrots and code in a world shining bright!
🐰 Hop on, let’s celebrate code done right!

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.48%. Comparing base (18dc41c) to head (c3a9749).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #266   +/-   ##
=======================================
  Coverage   54.47%   54.48%           
=======================================
  Files         206      206           
  Lines       17712    17714    +2     
=======================================
+ Hits         9649     9651    +2     
  Misses       8063     8063           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

components/bank/handlers/manifest/msgPayoutHandler.tsx (2)

31-39: LGTM! Consider making null handling more explicit.

The refactoring improves readability by using React fragments and proper JSX structure. The logic is correct and maintains the same functionality.

Consider making the null handling more explicit:

-    ) : pairs?.[0]?.address ? (
+    ) : pairs.length === 1 && pairs[0]?.address ? (

---

34-36: Consider consistent spacing across conditions.

For consistency in spacing, consider adding explicit spaces in all conditions.

     ) : pairs?.[0]?.address ? (
       <>
-        to <TruncatedAddressWithCopy address={pairs[0].address} slice={24} />{' '}
+        to{' '}<TruncatedAddressWithCopy address={pairs[0].address} slice={24} />{' '}
       </>

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 18dc41c and c3a9749.

⛔ Files ignored due to path filters (1)

• bun.lock is excluded by !**/*.lock

📒 Files selected for processing (1)

• components/bank/handlers/manifest/msgPayoutHandler.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build