chore: Remove the setTimeout from DenomImage #360

hansl · 2025-03-11T17:49:11Z

There is no point on waiting a second to give an illusion. Images are ready almost instantly and the user does not even see the loading skeleton most of the time.

This might also improve CI performance and fix the current failure.

Summary by CodeRabbit

Refactor
- Streamlined the image display process for a smoother user experience: images now render immediately based on source availability without showing temporary loading states.
- Enhanced visual presentation with updated styling and built-in animations, ensuring a more responsive, polished look during image transitions.

There is no point on waiting a second to give an illusion. Images are ready almost instantly and the user does not even see the loading skeleton most of the time. This might also improve CI performance and fix the current failure.

coderabbitai · 2025-03-11T17:49:20Z

Walkthrough

The changes simplify the DenomImage component by removing the loading state and associated logic. The component no longer uses the isLoading state or the checkUri function. It now directly checks whether denom.uri is present and updates the image support state accordingly. The conditional rendering for a loading skeleton is removed, and the image components now include the appropriate loading styles. Similarly, the tests were updated by removing the mocked setTimeout functions and related assertions, with focus solely on rendering based on the provided denom properties.

Changes

File(s)	Change Summary
`components/.../DenomImage.tsx`	Removed `isLoading` state, the `checkUri` function, and conditional loading skeleton rendering. Now directly checks `denom.uri` and sets support.
`components/.../__tests__/DenomImage.test.tsx`	Removed mocked `$setTimeout` and related assertions; eliminated tests for the loading state, focusing on rendering based on `denom` properties.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant DI as DenomImage
    participant I as Image Renderer
    participant A as Avatar Renderer

    U->>DI: Pass denom object with uri
    DI->>DI: Check if denom.uri exists
    alt Valid URI
       DI->>I: Render image with loading styles 
    else Invalid URI
       DI->>A: Render fallback avatar
    end

Poem

Hop, hop, the code is light,
No more waiting through the night.
I ditched the timeout cheeky spree,
Now images load as quick as can be!
With every line I wiggle with glee,
This rabbit cheers simplicity!
🥕🐇

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8a1777d and fa2d8aa.

⛔ Files ignored due to path filters (1)

components/factory/components/__tests__/__snapshots__/DenomImage.test.tsx.snap is excluded by !**/*.snap

📒 Files selected for processing (2)

components/factory/components/DenomImage.tsx (3 hunks)
components/factory/components/__tests__/DenomImage.test.tsx (0 hunks)

💤 Files with no reviewable changes (1)

components/factory/components/tests/DenomImage.test.tsx

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: build

🔇 Additional comments (3)

components/factory/components/DenomImage.tsx (3)

80-82: Improved state management by removing unnecessary loading delay

The simplified useEffect hook now directly updates the isSupported state based on the URI without an artificial delay. This is a good improvement that makes the component more responsive and easier to reason about.

96-96: Better loading state handling with CSS data attributes

Moving from conditionally rendered loading states to CSS data attributes is a cleaner approach. This leverages Next.js Image component's built-in loading behavior instead of manually managing loading state with setTimeout.

118-118: Consistent loading animation patterns across image instances

The loading animation styling is now consistently applied across all image instances in the component. This declarative approach using data attributes is more maintainable than managing loading states with setTimeout.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-03-11T17:50:32Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.17%. Comparing base (d1a2ab9) to head (fa2d8aa).
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
+ Coverage   55.18%   56.17%   +0.98%     
==========================================
  Files         225      228       +3     
  Lines       16508    16530      +22     
==========================================
+ Hits         9110     9285     +175     
+ Misses       7398     7245     -153

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

fmorency

ACK

chore: Remove the setTimeout from DenomImage

fa2d8aa

There is no point on waiting a second to give an illusion. Images are ready almost instantly and the user does not even see the loading skeleton most of the time. This might also improve CI performance and fix the current failure.

fmorency approved these changes Mar 11, 2025

View reviewed changes

fmorency merged commit 1ee479b into liftedinit:main Mar 11, 2025
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Remove the setTimeout from DenomImage #360

chore: Remove the setTimeout from DenomImage #360

hansl commented Mar 11, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 11, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

codecov bot commented Mar 11, 2025 •

edited

Loading

fmorency left a comment

chore: Remove the setTimeout from DenomImage #360

chore: Remove the setTimeout from DenomImage #360

Conversation

hansl commented Mar 11, 2025 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Mar 11, 2025 • edited Loading

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

codecov bot commented Mar 11, 2025 • edited Loading

Codecov Report

fmorency left a comment

Choose a reason for hiding this comment

hansl commented Mar 11, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 11, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Mar 11, 2025 •

edited

Loading