chalabi/skip widget #363
chalabi/skip widget #363
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
| el => | ||
| el instanceof HTMLElement && | ||
| el.tagName === 'DIV' && | ||
| (el.className.includes('sc-iuUfFv') || el.className.includes('sc-dprtRQ')) |
There was a problem hiding this comment.
These are not guaranteed to work when they release a new version, as they're obviously mangled.
There was a problem hiding this comment.
I believe the next version will make shadow-dom optional
| if (allInputs.filter(Boolean).length > 0) { | ||
| // Get all the buttons and other interactive elements inside the modal | ||
| const modalContent = document.querySelector('.rc-virtual-list-holder-inner'); | ||
| const searchInput = document.querySelector('input[placeholder="Search for an asset"]'); |
There was a problem hiding this comment.
I think you should simply use the same selector strategy I used in my PR (check if there's an open div in a shadow root). It's broad but until we include other widgets with their own shadow dom it will do.
You can verify there's only 2 shadow dom elements in the document as a unit test. Or can you? Not sure how the skip go widget works :/
There was a problem hiding this comment.
I think I did what you asked here. Will worry about unit tests tomorrow.
This PR adds the skip/widget to the cross-chain tab in the send modal
There are a couple hacky solutions for integrating the skip widget.
v1.0.10in order to add theShadowScopeConfigProviderwith a config that disables declarative Shadow DOM in order to propagate click events to the Skip Widget.IbcSendFormThe Skip team told me they would add an option to disable Shadow DOM usage which would be our preffered solution. We will upgrade to this on release which will allow us to remove our hacky solutions.
All that remains are the 500 code responses from the manifest api in the skip widget.
This PR also includes a asset list fix to showcase axl and osmo sent over IBC on manifest. We can remove this when this chain-registry pr gets merged.