chore: documentation #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
=======================================
Coverage ? 18.59%
=======================================
Files ? 39
Lines ? 6826
Branches ? 0
=======================================
Hits ? 1269
Misses ? 5446
Partials ? 111 ☔ View full report in Codecov by Sentry. |
fmorency
requested changes
Mar 18, 2024
fmorency
reviewed
Mar 18, 2024
fmorency
reviewed
Mar 18, 2024
Co-authored-by: Félix C. Morency <[email protected]> Signed-off-by: Reece Williams <[email protected]>
Co-authored-by: Félix C. Morency <[email protected]> Signed-off-by: Reece Williams <[email protected]>
Signed-off-by: Reece Williams <[email protected]>
|
@chalabi2 @Reecepbcups is this PR ready for re-review/merge? |
Closed
|
@fmorency yes. The things I did not reply too are because I don't quite understand the need, chalabi probably knows more / better such as #18 (comment) |
fmorency
reviewed
Mar 25, 2024
Co-authored-by: Félix C. Morency <[email protected]> Signed-off-by: Joseph Chalabi <[email protected]>
fmorency
approved these changes
Mar 25, 2024
| @@ -234,10 +234,12 @@ The Token Factory module as it is implemented on the Manifest Network, allows an | |||
|
|
|||
| - Syntax: `manifestd tx token-factory create-denom [subdenom]` | |||
|
|
|||
| - Parameters: | |||
| - `subdenom`: The smallest denomination for your token e.g. udenom. | |||
| > _note:_ the createor of the denom is the denoms admin. | |||
There was a problem hiding this comment.
Suggested change
| > _note:_ the createor of the denom is the denoms admin. | |
| > _note:_ the creator of the denom is the denom admin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added contributing doc
Added Repo Readme
Added Security Doc
Updated Post Genesis Guide
Began POA_Guide
Description
Added more documentation. Readme descriibng the repo and features, Security contact details, contribution guidelines and updated the post genesis guide.
This pull request is not finished we still need:
Checklist: