-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump poa to v0.50.4-0.20240822204205-cff1b71131dd #90
Conversation
WalkthroughThe changes involve an update to the versioning in the Changes
Sequence Diagram(s)Not applicable as the changes do not involve new features or modifications to control flow. Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
go.sum
is excluded by!**/*.sum
Files selected for processing (2)
- Makefile (1 hunks)
- go.mod (1 hunks)
Files skipped from review due to trivial changes (1)
- Makefile
Additional comments not posted (1)
go.mod (1)
50-50
: Verify the impact of thepoa
version update.The dependency version for
github.com/strangelove-ventures/poa
has been updated. Ensure that this version change does not introduce any breaking changes or regressions in the application.Run the following script to check for any breaking changes or updates in the release notes of the new
poa
version:
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
=======================================
Coverage 76.74% 76.74%
=======================================
Files 34 34
Lines 1802 1802
=======================================
Hits 1383 1383
Misses 327 327
Partials 92 92 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Can you also bump the poa version from interchaintest/go.mod
?
@@ -47,7 +47,7 @@ require ( | |||
github.com/spf13/cobra v1.8.0 | |||
github.com/spf13/pflag v1.0.5 | |||
github.com/spf13/viper v1.18.2 | |||
github.com/strangelove-ventures/poa v0.50.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you bump to 0.50.4
? Reece released it a couple of minutes ago.
Superseded by #91 |
Description
Bumps poa in order to fix an issue where the admin could not be queried via the rest endpoint.
Summary by CodeRabbit