Run dep check in travis-ci #332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is from a discussion on ligato#327 Similar to the vpp-agent [1] [2], run `dep check` in travis-ci with each commit and fail if someone adds vendored code without proper vendoring. [1] https://github.com/ligato/vpp-agent/blob/pantheon-dev/.travis.yml#L41 [2] https://github.com/ligato/vpp-agent/blob/pantheon-dev/Makefile#L179-L181 Signed-off-by: Kyle Mestery <[email protected]>
|
@ondrej-fabry Did we want to iterate on this one or #331? |
Signed-off-by: Kyle Mestery <[email protected]>
|
Closing in lieu of #331. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is from a discussion on #327
Similar to the vpp-agent [1] [2], run
dep checkin travis-ci with eachcommit and fail if someone adds vendored code without proper vendoring.
[1] https://github.com/ligato/vpp-agent/blob/pantheon-dev/.travis.yml#L41
[2] https://github.com/ligato/vpp-agent/blob/pantheon-dev/Makefile#L179-L181
Signed-off-by: Kyle Mestery [email protected]