Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Wire for dependency injection #429

Draft
wants to merge 3 commits into
base: config
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update wire
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
ondrej-fabry committed May 4, 2020
commit 9026eb56fc62f2bc490792c0db82ccd78a02cf51
12 changes: 0 additions & 12 deletions core.go
Original file line number Diff line number Diff line change
@@ -32,18 +32,6 @@ var WireDefaultLogRegistry = wire.NewSet(
wire.InterfaceValue(new(logging.Registry), logging.DefaultRegistry),
)

/*func CoreProvider(
ServiceLabel servicelabel.ReaderAPI,
StatusCheck statuscheck.PluginStatusWriter,
LogRegistry logging.Registry,
) Core {
return Core{
ServiceLabel: ServiceLabel,
StatusCheck: StatusCheck,
LogRegistry: LogRegistry,
}
}*/

type Core struct {
LogRegistry logging.Registry
LogManager *logmanager.Plugin