MSRV 1.85 and Rust edition 2024 #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y with edition 2024 Co-authored-by: hombit <[email protected]>
Co-authored-by: hombit <[email protected]>
Co-authored-by: hombit <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR updates the minimum supported Rust version (MSRV) from 1.67 to 1.85 and upgrades the Rust edition from 2021 to 2024 across all three crates in the workspace. The MSRV bump enables the use of cargo's MSRV-aware dependency resolver and removes previous version constraints on cxx and cxx-build dependencies that were needed for MSRV 1.67/1.70 compatibility.
Key changes:
- Bumped all crate versions from 0.4.x to 0.5.0 (breaking change)
- Updated rust-version field to 1.85.0 and edition to 2024 in all Cargo.toml files
- Removed version upper bounds on
cxxandcxx-builddependencies, allowing latest 1.x versions
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Updated main crate to version 0.5.0, edition 2024, and rust-version 1.85.0 |
| ceres-solver-sys/Cargo.toml | Updated to version 0.5.0, edition 2024, rust-version 1.85.0; removed cxx version constraints and cmake build dependency |
| ceres-solver-src/Cargo.toml | Updated to version 0.5.0, edition 2024, and rust-version 1.85.0 |
| src/solver.rs | Automatic import reordering (alphabetical) due to Rust 2024 edition formatting |
| .github/workflows/test.yml | Updated CI test matrix to use Rust 1.87 instead of 1.67 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump minimum supported Rust version to 1.85 and Rust edition to 2024, which would allow us to benefit from msrv-aware dependency resolver with cargo