Fix SaaS Demo: adjust ai hints #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request simplifies AI hints across the demo models by removing special characters (backticks, arrow symbols, parentheses) and making the language more concise and natural. The changes improve readability for AI processing while maintaining the essential guidance about model usage. Additionally, a new ROI metric is added to the leads model to track marketing return on investment.
Key changes:
- Removed backticks from field references (e.g.,
conversion_rate→ conversion_rate) - Replaced arrow symbols with plain text (e.g., → becomes "to")
- Simplified explanatory parentheses into natural language flow
- Added new ROI metric to measure lead cost effectiveness
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| models/demo/leads.yml | Simplified all AI hints by removing special characters and verbose explanations; added new ROI metric for marketing analysis |
| models/demo/deals.yml | Simplified all AI hints by removing special characters and verbose explanations for consistency with leads model |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
torimwhaley
changed the title
Simplified AI hints across deals and leads models by: - Removing verbose explanations and reducing to essential guidance - Replacing special characters (arrows, em dashes, backticks) with plain text - Using "from X to Y" instead of arrow symbols - Using "like" instead of "e.g." with parentheses - Removing backticks around field names for cleaner appearance 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
torimwhaley
force-pushed
the
origin/partner-program-ai-demo
branch
from
a89ccea to
0a65493
Compare
Lightdash Validation Results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
making the AI hints less verbose and with no special characters