[python-package] remove unnecessary LGBM_BoosterGetCurrentIteration() call#7350
Open
jameslamb wants to merge 1 commit into
Open
[python-package] remove unnecessary LGBM_BoosterGetCurrentIteration() call#7350jameslamb wants to merge 1 commit into
jameslamb wants to merge 1 commit into
Conversation
jameslamb
commented
Jul 3, 2026
| """ | ||
| # ensure that existing Booster is freed before replacing it | ||
| # with a new one createdfrom file | ||
| # with a new one created from file |
Member
Author
There was a problem hiding this comment.
noticed this typo when looking back at the diff of #5961 and oop, it's still here 3 years later 😅
jameslamb
changed the title
jameslamb
requested review from
StrikerRUS,
borchero,
guolinke,
jmoralez,
mayer79 and
shiyu1994
as code owners
jameslamb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_InnerPredictor.from_booster()callsLGBM_BoosterGetCurrentIteration()but doesn't do anything with the return value. I don't think the package is depending on any side effect from that call and I don't see a place where_InnerPredictorwould need that value, so I think this is just unnecessary code left behind by the refactoring in #5961This removes it.