New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pym embedding #23

Open

freeman-lab wants to merge 2 commits into master from pym-embedding

Member

freeman-lab commented Aug 3, 2015

This PR is an attempt to use pym to embed visualizations within notebooks instead of the current approach of getting html from the embed link.

The advantages would be:

An easy way to specify a global target size for visualizations, similar the different sizing "contexts" in seaborn. This fixes the current problem that many visualizations end up unreasonably wide, and unless they have a very horizontal aspect ratio, they fall off the page.
Streaming updates happen immediately within notebooks!

And by using pym we still get dynamic height adjustment. Seems like an overall win, but there may be disadvantages I'm missing.

This implementation doesn't quite work yet, due to a pym not defined error in the browser that I'm trying to debug, but hopefully it's close.

cc @mathisonian

freeman-lab added 2 commits

August 3, 2015 19:18


          Add getter for pym html

24153a9


          Use pym to format

235bd9a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet