Upgrade VSS encryption and obfuscation scheme #627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! This PR is now in draft status. |
tnull
force-pushed
the
2025-08-upgrade-vss-encryption-obfuscation-scheme
branch
from
ac8ae88 to
3490f2a
Compare
tnull
force-pushed
the
2025-08-upgrade-vss-encryption-obfuscation-scheme
branch
2 times, most recently
from
bec8829 to
e977a6d
Compare
tnull
force-pushed
the
2025-08-upgrade-vss-encryption-obfuscation-scheme
branch
3 times, most recently
from
c7fc423 to
dd9a9e0
Compare
tnull
force-pushed
the
2025-08-upgrade-vss-encryption-obfuscation-scheme
branch
2 times, most recently
from
bd46497 to
5d2c43a
Compare
We bump our `vss-client` dependency to include the changes to the `StorableBuilder` interface. Previously, we the `vss-client` didn't allow to set `ChaCha20Poly1305RFC`'s `aad` field, which had the `tag` not commit to any particular key. This would allow a malicious VSS provider to substitute blobs stored under a different key without the client noticing. Here, we now set the `aad` field to the key under which the `Storable` will be stored, ensuring that the retrieved data was originally stored under the key we expected. We also account for `StorableBuilder` now taking `data_decryption_key` by reference on `build`/`deconstruct`.
tnull
force-pushed
the
2025-08-upgrade-vss-encryption-obfuscation-scheme
branch
from
5d2c43a to
656b188
Compare
We recently dropped the `Retry` logic in `vss-client-ng`, and rather now lean on `reqwest`'s retry logic. Here, we account for the corresponding interface changes.
We previously attempted to drop the internal runtime from `VssStore`, resulting into blocking behavior. While we recently made changes that improved our situation (having VSS CI pass again pretty reliably), we just ran into yet another case where the VSS CI hung (cf. https://github.com/lightningdevkit/vss-server/actions/runs/19023212819/job/54322173817?pr=59). Here we attempt to restore even more of the original pre- ab3d78d / lightningdevkit#623 behavior to get rid of the reappearing blocking behavior, i.e., only use the internal runtime in `VssStore`.
Now that we rely on `reqwest` v0.12.* retry logic as well as client-side timeouts, we can address the remaining TODOs here and simply drop the redundant `tokio::timeout`s we previously added as a safeguard to blocking tasks (even though in the worst cases we saw they never actually fired).
As LDK currently will still panic and crash if we'd ever fail a `write` operation, we here considerably bump the defaults set in `VssClient` to at least make this less likely. Longer term, we still hope to mitigate the issue by moving to the async-persist flow.
tnull
force-pushed
the
2025-08-upgrade-vss-encryption-obfuscation-scheme
branch
from
656b188 to
e1615e1
Compare
tnull
force-pushed
the
2025-08-upgrade-vss-encryption-obfuscation-scheme
branch
from
e1615e1 to
96db24d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on lightningdevkit/vss-client#40
In this PR we'll fix minor issues with the data encryption and key obfuscation scheme currently employed by
VssStore.As these are breaking changes, we'll also include a migration procedure as part of this PR. Will be in draft until we have all parts ready.