-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #29 from jbesraa/add-2829-part-1
2829 review club
- Loading branch information
Showing
1 changed file
with
31 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
--- | ||
layout: pr | ||
date: 2024-02-23 | ||
title: "Add an implementation of mutual message exchange" | ||
pr: 2829 | ||
authors: [TheBlueMatt] | ||
components: ["bLIP31", "Mutual Message Exchange", "Bolt12"] | ||
host: jbesraa | ||
status: upcoming | ||
commit: | ||
--- | ||
|
||
## Notes | ||
This is part one of the review for [bLIP/31] named "Mutual Message Exchange". | ||
In this part, we will review the bLIP, and in the next session we will review | ||
the implementation at [ldk/2829]. | ||
|
||
|
||
## Questions | ||
1. Did you review bLIP31? [Concept ACK, approach ACK, tested ACK, or NACK](https://github.com/lightningdevkit/rust-lightning/blob/master/CONTRIBUTING.md#peer-review)? | ||
2. What are the capabilities [bLIP/31] introduces? | ||
3. Who initiates the messaging process? What are the pros/cons? | ||
4. How does [bLIP/31] relate to [bolt/11] and [bolt/12]? | ||
5. How does the message sender know they are able to exchange a message with the recipient? | ||
|
||
[ldk/2829]: https://github.com/lightningdevkit/rust-lightning/pull/2829 | ||
[bLIP/31]: https://github.com/lightning/blips/pull/31/files | ||
[bolt/11]: https://github.com/lightning/bolts/blob/master/11-payment-encoding.md | ||
[bolt/12]: https://github.com/lightning/bolts/blob/9118a8f6be5bc08b7bc28fc2b4ebfed433900a9c/12-offer-encoding.md | ||
|
||
|