Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2829 review club #29

Merged
merged 1 commit into from
Feb 21, 2024
Merged

2829 review club #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions _posts/2024-02-23-#2829.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
---
layout: pr
date: 2024-02-23
title: "Add an implementation of mutual message exchange"
pr: 2829
authors: [TheBlueMatt]
components: ["bLIP31", "Mutual Message Exchange", "Bolt12"]
host: jbesraa
status: upcoming
commit:
---

## Notes
This is part one of the review for [bLIP/31] named "Mutual Message Exchange".
In this part, we will review the bLIP, and in the next session we will review
the implementation at [ldk/2829].


## Questions
1. Did you review bLIP31? [Concept ACK, approach ACK, tested ACK, or NACK](https://github.com/lightningdevkit/rust-lightning/blob/master/CONTRIBUTING.md#peer-review)?
2. What are the capabilities [bLIP/31] introduces?
3. Who initiates the messaging process? What are the pros/cons?
4. How does [bLIP/31] relate to [bolt/11] and [bolt/12]?
5. How does the message sender know they are able to exchange a message with the recipient?

[ldk/2829]: https://github.com/lightningdevkit/rust-lightning/pull/2829
[bLIP/31]: https://github.com/lightning/blips/pull/31/files
[bolt/11]: https://github.com/lightning/bolts/blob/master/11-payment-encoding.md
[bolt/12]: https://github.com/lightning/bolts/blob/9118a8f6be5bc08b7bc28fc2b4ebfed433900a9c/12-offer-encoding.md