Introduce &RoutingFees to channel_penalty_msat #2510
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be used to introduce costumzied filters based on fees
jbesraa
commented
Aug 21, 2023
| } else { | ||
| let curr_hop_path_idx = path.hops.len() - 1 - idx; | ||
| scorer.channel_penalty_msat(hop.short_channel_id, &NodeId::from_pubkey(&path.hops[curr_hop_path_idx - 1].pubkey), &NodeId::from_pubkey(&hop.pubkey), usage, &()); | ||
| scorer.channel_penalty_msat(hop.short_channel_id, &NodeId::from_pubkey(&path.hops[curr_hop_path_idx - 1].pubkey), &NodeId::from_pubkey(&hop.pubkey), usage, &(), &RoutingFees { base_msat: 0, proportional_millionths: 0 }); |
There was a problem hiding this comment.
not sure about this one..
how to get base_mast and proportional_millionths from RouteHop tho?
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2510 +/- ##
==========================================
- Coverage 90.40% 90.38% -0.02%
==========================================
Files 106 106
Lines 56268 56274 +6
Branches 56268 56274 +6
==========================================
- Hits 50868 50865 -3
- Misses 5400 5409 +9
☔ View full report in Codecov by Sentry. |
|
Sorry, a bunch of conversation on #2509 (comment) - do you want to give exposing the full |
|
@TheBlueMatt added some comments in the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2509