-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aggregate BlindedPayInfo
for blinded routes
#2514
Aggregate BlindedPayInfo
for blinded routes
#2514
Conversation
d60f441
to
63025f8
Compare
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2514 +/- ##
========================================
Coverage 90.59% 90.59%
========================================
Files 110 110
Lines 57410 58062 +652
Branches 57410 58062 +652
========================================
+ Hits 52008 52602 +594
- Misses 5402 5460 +58
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
63025f8
to
e87c68e
Compare
b159729
to
35b1dc8
Compare
c6df2b6
to
4b9f000
Compare
4b9f000
to
3ec7789
Compare
Rebased to fix CI. I added test coverage for the min htlc computation to #2413 so this should be good for review. |
f272645
to
5d0a982
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorta confused by htlc_minimum_msat
, everything else looks good
5d0a982
to
4777c29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, sorry for all the noise here, only one comment left I think.
4777c29
to
a6f881b
Compare
I think I addressed all feedback. Thought I saw something about not decrementing htlc_min but I don't see it anymore? |
a6f881b
to
88a0063
Compare
61658ae
to
a1b3fbb
Compare
These should've been made public when they were added for use in BlindedPath::new_for_payment.
impl_writeable_tlv_based includes a length prefix to the TLV stream, which we don't want.
a1b3fbb
to
f3616e6
Compare
BOLT 12 invoices encode
BlindedPayInfo
(s) as part of their hints for routing, whose fields are computed by aggregating fee/cltv/etc values from the hops along the blinded path. Helps address #1970.Based on #2412.