Zero fee commitment test vectors

[carlaKC]

Needs some serious cleaning up, so please don't review yet!

Opening up early because I'll be out till the 10th, want to have a passing version of these up in the meantime.

[ldk-reviews-bot]

🎉 This PR is now ready for review!
Please choose at least one reviewer by assigning them on the right bar.
If no reviewers are assigned within 10 minutes, I'll automatically assign one.
Once the first reviewer has submitted a review, a second will be assigned if required.

[codecov]

Codecov Report

❌ Patch coverage is 42.85714% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.31%. Comparing base (ec0b969) to head (c9bd30a).
⚠️ Report is 27 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/util/test_utils.rs	42.85%	12 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4202      +/-   ##
==========================================
- Coverage   89.34%   89.31%   -0.03%     
==========================================
  Files         180      180              
  Lines      138166   138178      +12     
  Branches   138166   138178      +12     
==========================================
- Hits       123438   123420      -18     
- Misses      12123    12153      +30     
  Partials     2605     2605              

Flag	Coverage Δ
fuzzing	35.81% <0.00%> (-0.02%)	⬇️
tests	88.69% <42.85%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ldk-reviews-bot]

🔔 1st Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

[ldk-reviews-bot]

🔔 2nd Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

[ldk-reviews-bot]

🔔 3rd Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

[ldk-reviews-bot]

🔔 4th Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

[carlaKC]

Rebased + cleaned this up - ready for a look now. Two notes for reviewers:

• There are quite a few thin from_hex helpers, IMO they help with readability quite a lot so are worth having.
• Didn't move this into its own file because it would require making a whole bunch of things pub(crate), happy to do so if there's strong preferences!

[ldk-reviews-bot]

🔔 5th Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

[ldk-reviews-bot]

🔔 6th Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

[TheBlueMatt]

Yay, good to see this mess cleaned up a bit 🎉. Didn't bother to validate the test vectors were copied correctly but I trust you on that.